Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp270150pxx; Thu, 29 Oct 2020 02:05:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkE1F/Wh9F6yDKX7DM7cGdRMinZv+fQTJtZagc6HE3munFYE1tTkSLDMU6lCgN/4YZ0ic/ X-Received: by 2002:a17:906:d048:: with SMTP id bo8mr3248716ejb.80.1603962339268; Thu, 29 Oct 2020 02:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603962339; cv=none; d=google.com; s=arc-20160816; b=op4w9fJMYNVnjIDHO0Ov+wVTV798l6pyx/q+PKwXf/Jz5N84xUXixMm9QZ4uR0ezOV HyiWooq+nAYzNuZI5RqEqW229NtCaMhUJaE4id4b9/G01zbiEOC5LIykZwcN7HuiGvxo 96ZADS5R7X17pSLQj7MMxF0Fu7hIkdz1xl+BdnqMF5NvPbUiGxx7C4NgJoeAViZqdQ/N C2aNkktEyNDoajDgJ4JbzCDkbE8O55MRyv/QGh7SLvAeNORAoGDne2wz2U3rx8m6YWT7 XrJivVCv/4f29NeSCu8WhgwmDdqdD3qqkylRPqMcOv3IqNUeQrGJTsShnJwigByrP7s+ i2rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=G4lTLcbLrH1AFXBGhkY06bVTyfFm6e2ukrwEoDh1yw8=; b=gmO4nNsZw4J+ocDU3IbMZmB8rjdgYcmX97YWdY5h1tLMiwBMHCXEbqQaPu4R/AY5Fy ltmtZ1PNgevvegxKC4s8g8RTvrH8RV+56AU4kndX6I3sXUMCkF8XpkE/ZA8I3X0njiJj /idBB29VejSHPV19XYMHcZXhvdDIMYet7a7NOgZVrUKZi6PS91wsJMXStonq6iWUIWbI 5QHGGs6uO8xoy0UrYeLanvWqAH5M09dm2MXijbQ4MxQDnWF/qAAS99mMECU13zFID+Jf EDbpCEM1N0VRpGBKoenyywB0yZjILp+X6qvcxUQLqMihpmbrkPJDjllCRShJJpPWXXNo TCGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d15si896929edx.442.2020.10.29.02.05.17; Thu, 29 Oct 2020 02:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732542AbgJ2H5Q (ORCPT + 99 others); Thu, 29 Oct 2020 03:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727018AbgJ2HYk (ORCPT ); Thu, 29 Oct 2020 03:24:40 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B27FC0613D3; Wed, 28 Oct 2020 19:44:37 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXxvX-00B2OP-P0; Thu, 29 Oct 2020 02:44:35 +0000 Date: Thu, 29 Oct 2020 02:44:35 +0000 From: Al Viro To: zc Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] fs:regfs: add register easy filesystem Message-ID: <20201029024435.GO3576660@ZenIV.linux.org.uk> References: <1603175408-96164-1-git-send-email-zoucao@linux.alibaba.com> <00513aa5-1cc5-bc1c-1ca7-d5cd6e3f1ed6@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2020 at 02:27:20PM +0800, zc wrote: > Hi viro: > > ?? have time for reviewing this? Start with removing unused boilerplate. When quite a chunk of the codebase is simply never used, filtering _that_ out is on the author, not reviewers.