Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Oct 2020 08:48:55 +0100
Message-ID: <s5hpn51wjyw.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Coiby Xu <coiby.xu@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org (moderated list:SOUND),
        linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 01/25] ALSA: core: pcm: remove unnecessary CONFIG_PM_SLEEP
In-Reply-To: <20201029074301.226644-1-coiby.xu@gmail.com>
References: <20201029074301.226644-1-coiby.xu@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 29 Oct 2020 08:42:37 +0100,
Coiby Xu wrote:
> 
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
> 
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>

It caused compile warnings.  Was it already addressed in general?

Or we may use __maybe_unused attribute instead, but it's just a matter
of taste.


thanks,

Takashi

> ---
>  sound/core/pcm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/core/pcm.c b/sound/core/pcm.c
> index be5714f1bb58..5a281ac92958 100644
> --- a/sound/core/pcm.c
> +++ b/sound/core/pcm.c
> @@ -599,7 +599,6 @@ static const struct attribute_group *pcm_dev_attr_groups[];
>   * PM callbacks: we need to deal only with suspend here, as the resume is
>   * triggered either from user-space or the driver's resume callback
>   */
> -#ifdef CONFIG_PM_SLEEP
>  static int do_pcm_suspend(struct device *dev)
>  {
>  	struct snd_pcm_str *pstr = container_of(dev, struct snd_pcm_str, dev);
> @@ -608,7 +607,6 @@ static int do_pcm_suspend(struct device *dev)
>  		snd_pcm_suspend_all(pstr->pcm);
>  	return 0;
>  }
> -#endif
>  
>  static const struct dev_pm_ops pcm_dev_pm_ops = {
>  	SET_SYSTEM_SLEEP_PM_OPS(do_pcm_suspend, NULL)
> -- 
> 2.28.0
>