Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: tdas=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 56DD3C433FF
Subject: Re: [PATCH v5 1/2] clk: qcom: lpasscc-sc7810: Use devm in probe
To:     Douglas Anderson <dianders@chromium.org>,
        Stephen Boyd <sboyd@kernel.org>
Cc:     David Brown <david.brown@linaro.org>,
        Rajendra Nayak <rnayak@codeaurora.org>,
        linux-soc@vger.kernel.org, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20201019154857.v5.1.I4567b5e7e17bbb15ef063d447cb83fd43746cb18@changeid>
From:   Taniya Das <tdas@codeaurora.org>
Message-ID: <669a0546-f6d9-6b68-207f-eb75832041fa@codeaurora.org>
Date:   Thu, 29 Oct 2020 14:32:16 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.3
MIME-Version: 1.0
In-Reply-To: <20201019154857.v5.1.I4567b5e7e17bbb15ef063d447cb83fd43746cb18@changeid>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Reviewed-by: Taniya Das <tdas@codeaurora.org>

On 10/20/2020 4:19 AM, Douglas Anderson wrote:
> Let's convert the lpass clock control driver to use devm.  This is a
> few more lines of code, but it will be useful in a later patch which
> disentangles the two devices handled by this driver.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> 
> (no changes since v4)
> 
> Changes in v4:
> - Fixed typo lapss => lpass
> - Moved lpass_pm_runtime_disable() lpass_pm_clk_destroy() in file.
> 
> Changes in v3:
> - ("clk: qcom: lpasscc-sc7810: Use devm in probe") new for v3.
> 
>   drivers/clk/qcom/lpasscorecc-sc7180.c | 38 +++++++++++++++------------
>   1 file changed, 21 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c b/drivers/clk/qcom/lpasscorecc-sc7180.c
> index 228d08f5d26f..2d15e33ec837 100644
> --- a/drivers/clk/qcom/lpasscorecc-sc7180.c
> +++ b/drivers/clk/qcom/lpasscorecc-sc7180.c
> @@ -356,6 +356,16 @@ static const struct qcom_cc_desc lpass_audio_hm_sc7180_desc = {
>   	.num_gdscs = ARRAY_SIZE(lpass_audio_hm_sc7180_gdscs),
>   };
>   
> +static void lpass_pm_runtime_disable(void *data)
> +{
> +	pm_runtime_disable(data);
> +}
> +
> +static void lpass_pm_clk_destroy(void *data)
> +{
> +	pm_clk_destroy(data);
> +}
> +
>   static int lpass_core_cc_sc7180_probe(struct platform_device *pdev)
>   {
>   	const struct qcom_cc_desc *desc;
> @@ -418,34 +428,28 @@ static int lpass_core_sc7180_probe(struct platform_device *pdev)
>   	int ret;
>   
>   	pm_runtime_enable(&pdev->dev);
> +	ret = devm_add_action_or_reset(&pdev->dev, lpass_pm_runtime_disable, &pdev->dev);
> +	if (ret)
> +		return ret;
> +
>   	ret = pm_clk_create(&pdev->dev);
>   	if (ret)
> -		goto disable_pm_runtime;
> +		return ret;
> +	ret = devm_add_action_or_reset(&pdev->dev, lpass_pm_clk_destroy, &pdev->dev);
> +	if (ret)
> +		return ret;
>   
>   	ret = pm_clk_add(&pdev->dev, "iface");
>   	if (ret < 0) {
>   		dev_err(&pdev->dev, "failed to acquire iface clock\n");
> -		goto destroy_pm_clk;
> +		return ret;
>   	}
>   
> -	ret = -EINVAL;
>   	clk_probe = of_device_get_match_data(&pdev->dev);
>   	if (!clk_probe)
> -		goto destroy_pm_clk;
> -
> -	ret = clk_probe(pdev);
> -	if (ret)
> -		goto destroy_pm_clk;
> -
> -	return 0;
> -
> -destroy_pm_clk:
> -	pm_clk_destroy(&pdev->dev);
> -
> -disable_pm_runtime:
> -	pm_runtime_disable(&pdev->dev);
> +		return -EINVAL;
>   
> -	return ret;
> +	return clk_probe(pdev);
>   }
>   
>   static const struct dev_pm_ops lpass_core_cc_pm_ops = {
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--