Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751073AbWHPJkz (ORCPT ); Wed, 16 Aug 2006 05:40:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751075AbWHPJkz (ORCPT ); Wed, 16 Aug 2006 05:40:55 -0400 Received: from dsl027-180-168.sfo1.dsl.speakeasy.net ([216.27.180.168]:27856 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S1751066AbWHPJky (ORCPT ); Wed, 16 Aug 2006 05:40:54 -0400 Date: Wed, 16 Aug 2006 02:40:08 -0700 (PDT) Message-Id: <20060816.024008.74744877.davem@davemloft.net> To: hch@infradead.org Cc: johnpol@2ka.mipt.ru, arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/1] network memory allocator. From: David Miller In-Reply-To: <20060816093837.GA11096@infradead.org> References: <20060816091029.GA6375@infradead.org> <20060816093159.GA31882@2ka.mipt.ru> <20060816093837.GA11096@infradead.org> X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 13 From: Christoph Hellwig Date: Wed, 16 Aug 2006 10:38:37 +0100 > We could, but I'd rather waste 4 bytes in struct net_device than > having such ugly warts in common code. Why not instead have struct device store some default node value? The node decision will be sub-optimal on non-pci but it won't crash. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/