Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp302262pxx; Thu, 29 Oct 2020 03:04:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8vOoWZh0ZaSHzZXUCyl0MZ3lhfTHnQct3VUSFuXYHVkLwXm9jU2OGQRD+uCMpU9RK1P+V X-Received: by 2002:a17:906:3789:: with SMTP id n9mr3280555ejc.273.1603965859361; Thu, 29 Oct 2020 03:04:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603965859; cv=none; d=google.com; s=arc-20160816; b=vakoc4YGc1UfiSxPpx7PUyzTrKQpVM/CIbV3A7gtzmbQPLmHcQDmtYb8yvwXVJLUo1 qR2Dbh6hTn6k4cwTI6x4SLUg78O5iN63Q+vHLAMzsp98R7Yt+ut/07Yf9G50ttSgRzA9 fZBh7OM/lEunQP/o2GQvHo58WWp2OHAfEUWMRCMkn2f0ek1rfdKnBbG+uUsBUSjHWLhW 2YMrD8qLGMXLR9YhxAlJdhb1FT5LFdVsgPtPDFjDlgp21pwexTxyYEDMeBlrM2nzbes/ w5IE9Oo5M99/cdTjXsX856PSepKjecqzxnBzGqFY6Ayb7653Ok1iWr6NK+vZwhdKO5Rm 9XWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bJJQrkz2DmvsLC/KQQtP+/G8oJcKg1SqkvfvGBG1Kis=; b=whAn6gnDyCq0lQUZEQGohvTHn5QJwnr6KZ3cDempJMokip4QFopvEqi/r6rs6ug5Qw hANWemaCyC5g07v8yGOsfBXGcb8ADnD7tyeeZXRxWCls3yRpBAB77PZa1kcF64YVU0Q8 cp8o3AnwiUyzuKIfCSrQFvemiT30tdViXCLLIQ0E6Xx1yMC9izjBUuLuQAcz+AWB9LvD kmKU+OzawA+n+6uhOa7zw1tn88etNpuRASiQYn1aBzBxxmhGGe6A4ksuf8nmaobGBaAE kNvNd7qFa13rjpWEYgGOkfY+3UeGeJzMYlp+ffQdAOayjbT05U1guDwB5CdwENshPhuo VH4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UIAwvXhE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y19si1344689ejd.730.2020.10.29.03.03.55; Thu, 29 Oct 2020 03:04:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UIAwvXhE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725814AbgJ2KCC (ORCPT + 99 others); Thu, 29 Oct 2020 06:02:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgJ2KCC (ORCPT ); Thu, 29 Oct 2020 06:02:02 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB4CCC0613CF; Thu, 29 Oct 2020 03:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bJJQrkz2DmvsLC/KQQtP+/G8oJcKg1SqkvfvGBG1Kis=; b=UIAwvXhE7HjAKmjqXHhRLl9xIu KdZK7e/fqvMm7rw2C3LqAZWCEoNoruvvPKUgUOyoKN58s/OwdGeINy+HwrgeVqArnWnrWryUY+jb2 royGa8LcqCMYxcXyw6E3NTJ5qcor1MUKOfrLFe6lmKdBULXWQ/gsxFST+ILBM5vpMTfivLaMPZ0n+ lwNr6d0yKwrW/JY6j7owx/oU7GPyKNkMlHL34diDPWpyASCTiVyUcN8P0tll8Al92jhTzzyoPZ7TQ SPduM45A4CaJpZqoSz2G8kug/654kfdn1ADp01H/bNB0YIohiOR0lAbAAi2em9I40rFtMfTVnxd9Z XBUKi7SQ==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY4kn-0002hM-SZ; Thu, 29 Oct 2020 10:01:57 +0000 Date: Thu, 29 Oct 2020 10:01:57 +0000 From: Christoph Hellwig To: Daniel Vetter Cc: Christoph Hellwig , DRI Development , LKML , KVM list , Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390 Subject: Re: [PATCH v4 00/15] follow_pfn and other iomap races Message-ID: <20201029100157.GA10041@infradead.org> References: <20201026105818.2585306-1-daniel.vetter@ffwll.ch> <20201029085749.GB25658@infradead.org> <20201029092800.GA494@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 10:38:16AM +0100, Daniel Vetter wrote: > Hm so Jason and me discussed this, but e.g. the s390 is safe with with > just the pagetable locks. So we'd need two versions. > > The more practical problem is that I haven't found a reasonable way to > check that a passed in mmu_notifier is registered against the mm we're > working on, and without that check it feels a bit silly. But if you > see how to do that I think we can do an EXPORT_SYMBOL_GPL follow_pfn > which takes the notifier, and an __follow_pfn for s390 and similar > internal code which isn't exported. True, this is a bit of a mess. So maybe just rename it to __follow_pfn, proper documentation of the requirements and a switch to EXPORT_SYMBOL_GPL.