Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Oct 2020 11:13:04 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Matteo Scordino <matteo.scordino@gmail.com>
Cc:     wens@csie.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings
Message-ID: <20201029101304.yja4m747pc62re34@gilmour.lan>
References: <20201029022000.601913-1-matteo.scordino@gmail.com>
 <20201029022000.601913-5-matteo.scordino@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="tfkoq4gmrgzotfz5"
Content-Disposition: inline
In-Reply-To: <20201029022000.601913-5-matteo.scordino@gmail.com>
Precedence: bulk


--tfkoq4gmrgzotfz5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Oct 29, 2020 at 02:19:59AM +0000, Matteo Scordino wrote:
> Document board compatible names for Elimo Engineering Impetus and Initium
>=20
> Signed-off-by: Matteo Scordino <matteo.scordino@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documenta=
tion/devicetree/bindings/arm/sunxi.yaml
> index 0f23133672a3..55405809ec91 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -898,3 +898,13 @@ properties:
>          items:
>            - const: xunlong,orangepi-zero-plus2-h3
>            - const: allwinner,sun8i-h3
> +
> +      - description: Elimo Engineering Impetus SoM
> +        items:
> +          - const: elimo,impetus
> +          - const: allwinner,sun8i-s3
> +
> +      - description: Elimo Engineering Initium
> +        items:
> +          - const: elimo,initium
> +          - const: allwinner,sun8i-s3

This should be ordered alphabetically, and most importantly, must match
the ones you have in the DT.

Here, we have kind of a mess already: the Lichee Zero+ uses
,sipeed,lichee-zero-plus, sochip,s3, allwinner,sun8i-v3, while the
pinecube uses pine64,pinecube, allwinner,sun8i-s3

IIRC the S3 and V3 are pretty much the same SoCs, so the first one seems
to make more sense to me, but then we should fix the pinecube.

Maxime

--tfkoq4gmrgzotfz5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX5qVsAAKCRDj7w1vZxhR
xVVIAQDmDDS/BMkDYVHnPMF1XcIGfuy3Sko7fl3gm9DEwtOe2wD+N68SO2iPczRJ
cwHDi17y9WbYOszqnj5SSrRBe3KFig4=
=43AT
-----END PGP SIGNATURE-----

--tfkoq4gmrgzotfz5--