Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
AI-Spam-Status: Not processed
Date:   Thu, 29 Oct 2020 18:24:34 +0800
User-Agent: K-9 Mail for Android
In-Reply-To: <20201029101304.yja4m747pc62re34@gilmour.lan>
References: <20201029022000.601913-1-matteo.scordino@gmail.com> <20201029022000.601913-5-matteo.scordino@gmail.com> <20201029101304.yja4m747pc62re34@gilmour.lan>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings
To:     Maxime Ripard <maxime@cerno.tech>,
        Matteo Scordino <matteo.scordino@gmail.com>
CC:     wens@csie.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>
From:   Icenowy Zheng <icenowy@aosc.io>
Message-ID: <92612D42-FF4C-450C-ADB1-A220B94838CB@aosc.io>
Precedence: bulk


=E4=BA=8E 2020=E5=B9=B410=E6=9C=8829=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88=
6:13:04, Maxime Ripard <maxime@cerno=2Etech> =E5=86=99=E5=88=B0:
>Hi,
>
>On Thu, Oct 29, 2020 at 02:19:59AM +0000, Matteo Scordino wrote:
>> Document board compatible names for Elimo Engineering Impetus and
>Initium
>>=20
>> Signed-off-by: Matteo Scordino <matteo=2Escordino@gmail=2Ecom>
>> ---
>>  Documentation/devicetree/bindings/arm/sunxi=2Eyaml | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>=20
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi=2Eyaml
>b/Documentation/devicetree/bindings/arm/sunxi=2Eyaml
>> index 0f23133672a3=2E=2E55405809ec91 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi=2Eyaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi=2Eyaml
>> @@ -898,3 +898,13 @@ properties:
>>          items:
>>            - const: xunlong,orangepi-zero-plus2-h3
>>            - const: allwinner,sun8i-h3
>> +
>> +      - description: Elimo Engineering Impetus SoM
>> +        items:
>> +          - const: elimo,impetus
>> +          - const: allwinner,sun8i-s3
>> +
>> +      - description: Elimo Engineering Initium
>> +        items:
>> +          - const: elimo,initium
>> +          - const: allwinner,sun8i-s3
>
>This should be ordered alphabetically, and most importantly, must match
>the ones you have in the DT=2E
>
>Here, we have kind of a mess already: the Lichee Zero+ uses
>,sipeed,lichee-zero-plus, sochip,s3, allwinner,sun8i-v3, while the
>pinecube uses pine64,pinecube, allwinner,sun8i-s3
>
>IIRC the S3 and V3 are pretty much the same SoCs, so the first one
>seems
>to make more sense to me, but then we should fix the pinecube=2E

I agree with this=2E

PineCube is originally designed for S3L (which is branded under Allwinner)
but switch to S3 finally, so I may made error when adapting=2E

>
>Maxime