Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp328460pxx; Thu, 29 Oct 2020 03:47:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXSTKwBXKR1ZcmQTtg5W9WmTZ15dLcgnncLvVcIcdv97yi7uT/Z0TK5Lhy8du/h03ah4Jz X-Received: by 2002:a17:906:838f:: with SMTP id p15mr3345150ejx.522.1603968450186; Thu, 29 Oct 2020 03:47:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603968450; cv=none; d=google.com; s=arc-20160816; b=YwzLfFlftGmuoM1K5GB47NkAMrJzp8sa/QhSIsz5hTY6x6VUmqjz7Rc6GbSSBRvk9P N1yml9mblmb2TBR++/ZDP6gMES97tRnGvn64hg/ulTPqWazhynzfy0Z2FvD4XtVanhNq lN2HHo6r5cdtoK0dBl8UtLbEKjpxHN/rrCSXE2qE2izoRF7Hrdy8HNqRoKUt7b7c8vFx NjguypXNM+zE3Uysd3nLVXR7aWkFK/I8oEnfbJNbpjPMMbgSfZ5cPFkqoOP1S0lZXAMJ Q4oB+NpOBFrqQ/vMdyoztfmXX2XdhkPez8NVPQTORhCay7u3aqsIS0+DTAL+hmrguWHZ 3WIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=mNG7NbOuJzC/2VyCcexzvTjHhSUqzKhB9D2X10Ipfns=; b=o+jH7ENERU6Vi0cdGmYB1cKLBLtARDxrDge0VCAW1Ie/RXNU9LLM9ujh+J0kBgr7VQ Xdfb7CvoLIvtgEpgrFndfUzbOrp7PHPVhmXIXaowP/2xWlcceZ+zXBsWGjuKcZ4FpmAF ahH64xt3cGYLvhuSKOJaRvhpqcOzfiknfNeCpI3LPwSKfQ5McBTNnC1YFFJMFYmz7IW7 yLfozEGa+JrEwzyacmTpO4XZ9G4z6jL2EiERw3MLIeSI7os0OrfTdp0nOCZeSac2N9YZ zJ0i288HcoJXWd0slZk8OJS/tP70o/gBsDfoAQyjWCBrgCNcrHcp/wKDiKahhekonZRx Cb6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy1si1515242edb.13.2020.10.29.03.47.07; Thu, 29 Oct 2020 03:47:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbgJ2Kpl (ORCPT + 99 others); Thu, 29 Oct 2020 06:45:41 -0400 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:56949 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726784AbgJ2Kph (ORCPT ); Thu, 29 Oct 2020 06:45:37 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0UDXwDyN_1603968328; Received: from aliy80.localdomain(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UDXwDyN_1603968328) by smtp.aliyun-inc.com(127.0.0.1); Thu, 29 Oct 2020 18:45:32 +0800 From: Alex Shi To: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Cc: Michal Hocko Subject: [PATCH v20 09/20] mm/memcg: add debug checking in lock_page_memcg Date: Thu, 29 Oct 2020 18:44:54 +0800 Message-Id: <1603968305-8026-10-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a debug checking in lock_page_memcg, then we could get alarm if anything wrong here. Suggested-by: Johannes Weiner Signed-off-by: Alex Shi Acked-by: Hugh Dickins Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/memcontrol.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e46b9f9501c2..599aa8863111 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2142,6 +2142,12 @@ struct mem_cgroup *lock_page_memcg(struct page *page) if (unlikely(!memcg)) return NULL; +#ifdef CONFIG_PROVE_LOCKING + local_irq_save(flags); + might_lock(&memcg->move_lock); + local_irq_restore(flags); +#endif + if (atomic_read(&memcg->moving_account) <= 0) return memcg; -- 1.8.3.1