Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Chunfeng Yun <chunfeng.yun@mediatek.com>
CC:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        "bcm-kernel-feedback-list@broadcom.com" 
        <bcm-kernel-feedback-list@broadcom.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Lubomir Rintel <lkundrak@v3.sk>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Colin Ian King <colin.king@canonical.com>,
        Ondrej Jirman <megous@megous.com>,
        Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Icenowy Zheng <icenowy@aosc.io>,
        Remi Pommarel <repk@triplefau.lt>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Yue Wang <yue.wang@amlogic.com>,
        Hanjie Lin <hanjie.lin@amlogic.com>,
        Joe Perches <joe@perches.com>,
        Bharat Gooty <bharat.gooty@broadcom.com>,
        Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
        Roger Quadros <rogerq@ti.com>, Jyri Sarha <jsarha@ti.com>,
        Sanket Parmar <sparmar@cadence.com>,
        Anil Varughese <aniljoy@cadence.com>, Jun Li <jun.li@nxp.com>,
        Ma Feng <mafeng.ma@huawei.com>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-amlogic@lists.infradead.org" 
        <linux-amlogic@lists.infradead.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 04/17] phy: cadence: convert to
 devm_platform_ioremap_resource
Thread-Topic: [PATCH 04/17] phy: cadence: convert to
 devm_platform_ioremap_resource
Thread-Index: AQHWrZ79HoPsXManfEu7l56QIQ802qmuZ0eA
Date:   Thu, 29 Oct 2020 10:50:34 +0000
Message-ID: <20201029105004.GC30677@b29397-desktop>
References: <1603940079-8131-1-git-send-email-chunfeng.yun@mediatek.com>
 <1603940079-8131-4-git-send-email-chunfeng.yun@mediatek.com>
In-Reply-To: <1603940079-8131-4-git-send-email-chunfeng.yun@mediatek.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E666853BC4238D4784104C8256E2F1AD@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b65114c3-b56e-44b3-4bfb-08d87bf8768d
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 10:50:34.3106
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Sej4EAnnGQLGZz+lWNl/3ubyGNRigeJ6d0R23DGvU5q3iUV5Jy1P8hNEWrGh9midwRSg2VnJ6s5qoqzoV4Ekhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6849
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-10-29 10:54:26, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource to simplify code
>=20
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  drivers/phy/cadence/cdns-dphy.c          | 4 +---
>  drivers/phy/cadence/phy-cadence-salvo.c  | 4 +---
>  drivers/phy/cadence/phy-cadence-sierra.c | 4 +---
>  3 files changed, 3 insertions(+), 9 deletions(-)
>=20
> diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-d=
phy.c
> index 90c4e9b5aac8..ba042e39cfaf 100644
> --- a/drivers/phy/cadence/cdns-dphy.c
> +++ b/drivers/phy/cadence/cdns-dphy.c
> @@ -314,7 +314,6 @@ static int cdns_dphy_probe(struct platform_device *pd=
ev)
>  {
>  	struct phy_provider *phy_provider;
>  	struct cdns_dphy *dphy;
> -	struct resource *res;
>  	int ret;
> =20
>  	dphy =3D devm_kzalloc(&pdev->dev, sizeof(*dphy), GFP_KERNEL);
> @@ -326,8 +325,7 @@ static int cdns_dphy_probe(struct platform_device *pd=
ev)
>  	if (!dphy->ops)
>  		return -EINVAL;
> =20
> -	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dphy->regs =3D devm_ioremap_resource(&pdev->dev, res);
> +	dphy->regs =3D devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(dphy->regs))
>  		return PTR_ERR(dphy->regs);
> =20
> diff --git a/drivers/phy/cadence/phy-cadence-salvo.c b/drivers/phy/cadenc=
e/phy-cadence-salvo.c
> index 88e239adc3b8..51c0b98f5fd7 100644
> --- a/drivers/phy/cadence/phy-cadence-salvo.c
> +++ b/drivers/phy/cadence/phy-cadence-salvo.c
> @@ -263,7 +263,6 @@ static int cdns_salvo_phy_probe(struct platform_devic=
e *pdev)
>  	struct phy_provider *phy_provider;
>  	struct device *dev =3D &pdev->dev;
>  	struct cdns_salvo_phy *salvo_phy;
> -	struct resource *res;
>  	const struct of_device_id *match;
>  	struct cdns_salvo_data *data;
> =20
> @@ -281,8 +280,7 @@ static int cdns_salvo_phy_probe(struct platform_devic=
e *pdev)
>  	if (IS_ERR(salvo_phy->clk))
>  		return PTR_ERR(salvo_phy->clk);
> =20
> -	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	salvo_phy->base =3D devm_ioremap_resource(dev, res);
> +	salvo_phy->base =3D devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(salvo_phy->base))
>  		return PTR_ERR(salvo_phy->base);
> =20
> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/caden=
ce/phy-cadence-sierra.c
> index 453ef26fa1c7..26a0badabe38 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -479,7 +479,6 @@ static int cdns_sierra_phy_probe(struct platform_devi=
ce *pdev)
>  	const struct of_device_id *match;
>  	struct cdns_sierra_data *data;
>  	unsigned int id_value;
> -	struct resource *res;
>  	int i, ret, node =3D 0;
>  	void __iomem *base;
>  	struct clk *clk;
> @@ -502,8 +501,7 @@ static int cdns_sierra_phy_probe(struct platform_devi=
ce *pdev)
>  	sp->dev =3D dev;
>  	sp->init_data =3D data;
> =20
> -	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base =3D devm_ioremap_resource(dev, res);
> +	base =3D devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base)) {
>  		dev_err(dev, "missing \"reg\"\n");
>  		return PTR_ERR(base);
> --=20
> 2.18.0

Acked-by: Peter Chen <peter.chen@nxp.com> for phy-cadence-salvo.c.

--=20

Thanks,
Peter Chen=