Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 10/15] iio: adc: stm32: remove unnecessary CONFIG_PM_SLEEP
To:     Coiby Xu <coiby.xu@gmail.com>
CC:     Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Alexandre Torgue <alexandre.torgue@st.com>
References: <20201029074910.227859-1-coiby.xu@gmail.com>
 <20201029074910.227859-10-coiby.xu@gmail.com>
From:   Fabrice Gasnier <fabrice.gasnier@st.com>
Message-ID: <0d58cf8c-997c-959f-f952-999b0d3acdb1@st.com>
Date:   Thu, 29 Oct 2020 12:31:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201029074910.227859-10-coiby.xu@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/29/20 8:49 AM, Coiby Xu wrote:
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
> 
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
>  drivers/iio/adc/stm32-adc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index b3f31f147347..42f9013730f8 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c
> @@ -1988,7 +1988,6 @@ static int stm32_adc_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#if defined(CONFIG_PM_SLEEP)

Hi Coiby,

This generates warnings when building with W=1 and CONFIG_PM_SLEEP=n.
Could you please add also "__maybe_unused" attribute in suspend / resume
routines below.

>  static int stm32_adc_suspend(struct device *dev)
             ^
e.g. like: static int __maybe_unused stm32_adc_...

>  {
>  	struct iio_dev *indio_dev = dev_get_drvdata(dev);
> @@ -2018,7 +2017,6 @@ static int stm32_adc_resume(struct device *dev)
>  
>  	return stm32_adc_buffer_postenable(indio_dev);
>  }
> -#endif
>  
>  #if defined(CONFIG_PM)

Same could be done also for runtime PM routines. For my own curiosity,
do you plan to do this as well ?

Best regards,
Fabrice
>  static int stm32_adc_runtime_suspend(struct device *dev)
>