Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: K9KMeXBIH5LPd66nPO9XhcYnJKV+SUN2ASkaBHqd0xxkI2utglbK8Y+B+17b8KZgk7EoRt6oyF
 lEt1Gl4xLxcw==
IronPort-SDR: tqxmH3YvnSIkn4qOpeh65alLfLY9lyzIJi1RBwJkNeFFecjaUULXWwjFgvmUBvkxkcf89WrvZD
 7ZCnddrWNkVA==
Date:   Thu, 29 Oct 2020 13:51:13 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Sakari Ailus <sakari.ailus@linux.intel.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Felipe Balbi <balbi@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-acpi@vger.kernel.org
Subject: Re: [PATCHv2 1/3] software node: Power management operations for
 software nodes
Message-ID: <20201029115113.GA2288851@kuha.fi.intel.com>
References: <20201029105941.63410-1-heikki.krogerus@linux.intel.com>
 <20201029105941.63410-2-heikki.krogerus@linux.intel.com>
 <20201029111303.GL26150@paasikivi.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201029111303.GL26150@paasikivi.fi.intel.com>
Precedence: bulk

On Thu, Oct 29, 2020 at 01:13:03PM +0200, Sakari Ailus wrote:
> These functions are doing pretty much the same thing but with different
> parameters. How about implementing a macro or a few, which would take all
> the parameters as arguments and return the function to call? A few variants
> may be needed. Individual functions performing different tasks would become
> very simple.

I would prefer to do that as the second step, if you guys don't mind.
I think this was already talked about, but maybe only internally.
Those macros should then be used also in other places where the same
steps are being executed, for example in drivers/base/power/domain.c.

thanks,

-- 
heikki