Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp373446pxx; Thu, 29 Oct 2020 04:54:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy25MR5YE3AsFbM0f/afp4bjzCNz3ai3y7L+atODRXOnmiChuZAZj6lTapJV7QPlvIwtn24 X-Received: by 2002:a05:6402:554:: with SMTP id i20mr3456572edx.384.1603972486868; Thu, 29 Oct 2020 04:54:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603972486; cv=none; d=google.com; s=arc-20160816; b=e1uE6Djs3NlsZtxWyN7E+YOLvZh5OI24chJLGEM2Hj3/6Gp6tRyFbPoKLqOjGPub2E 1D/AlTGsQ8S0nmTUvKOPZI/UhbnqCjvRQcxs6e2SYU41J0+eaL2ALWdKpvR76d8YO/1+ /Hn0421CVzAAwJbYQPUKfyPo6eaE1eH2fg4RRBHlau07dcCLWkZ5BcPnpDvV6lvl+oMK 4tWDZVEJUkvEFKetj+ac0msQNbFBsdZVwxySrKwfBeFiPoxrr29PdtAuqh9FFSNdMs8g oxfFuoDYSYYXxA0YqOlRTcYQzDYV1Oh/YsWQnXhvmN9/gHoZzYSQ8rlCwzAfMMPH/1wI Kp2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=U3m1CrvhBF5ZSjmNj0DT84Tf4MllZuPLAp7rAxUIIvk=; b=XTmSACQMGq2UKqpzev+l/w6JhO0C63QHsH5SaRzJTbkXmaPW3dPjml7RFRv/bccZg1 7llJ+0BVBZdjO16s4AWDDzS7CDVHeus3qKnwRwcM2yXVO6sRgaP4D0gc1i+Cb3YMxNzp RpZ04CGsJevq/snKzWxgT9iyxTyAlE4pIwmUH6Q7gS8WvC/s/RhjRs4tafGY/uNHnCOf rYUqBOVjt6uO4LNzv19cJNabZIaproWmzEa/ZwDcvakBTEACLGluY1VMye057Mot/kbO fEgl3bN6+d3oqZNAQKoeYO78a3cpv1blzs3oTcoH3qE4+QcY+0r4nj9aV6pxDPROT46A YhNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QbTdGARb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y24si1638990ejw.503.2020.10.29.04.54.20; Thu, 29 Oct 2020 04:54:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QbTdGARb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725796AbgJ2LwF (ORCPT + 99 others); Thu, 29 Oct 2020 07:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgJ2LwE (ORCPT ); Thu, 29 Oct 2020 07:52:04 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61728C0613CF; Thu, 29 Oct 2020 04:52:04 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id e15so2134805pfh.6; Thu, 29 Oct 2020 04:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U3m1CrvhBF5ZSjmNj0DT84Tf4MllZuPLAp7rAxUIIvk=; b=QbTdGARbBTH/u8+FxoM+algkxX8+k9z37QEV7DSMGJfl/VPaZif1EZtmt1UPut11q3 EVWLS4R53NN8MF8GXNC9B53c/zMgekULAhUJDxQcaP9OhOl6hs07H/rolO1r1S8LTb6L U9F+u8KsQORfQ8vk5gBSX+VyhXQR+aPOP8Xfe7sqlaL/YGd74cGwFuMp5mLQI9iNPUDK fl8rz6zWLVtrUO2NvrehBMxmypFHFhpbeTUuExptjP2+7zm69V3jh6vgxL3cp6x3rzMq OhlaBmJaLka7PZD6znS+RFKyKdCHMJvxhywJci0czrWINe3bKzaJi11Gfi/QnluAy5Jj Qalg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U3m1CrvhBF5ZSjmNj0DT84Tf4MllZuPLAp7rAxUIIvk=; b=nRNcpD2v/4L06ATsBDxBpBx8dbS/0nR85LXyqy49s6cw5BRipnuatxIJxmSaRwHyB5 +C/6QmuXkx3hqtg1fxCgAoxucyzPx0U8bYgm9IKbmJFDwTgCy4xaVSaJTRPYyXXaO2sh fBJAjYJmF2ZKNlmQY3ft9eIgBYZXNbKAMksDiUmO0gPuWmanfjAr1uqXshnwltPuU8Gd Hhrxvk18ShkE78TWHBOQ6Nqg8Q/tCfE/ikGManS+Xhzi7Crh182o5U4nJEFNKqNiLNpF b/NYo68vhIW6vH3kq5CttdSmbaf9kijJqTIncXVeBSBxAA0p7XgXDkBnNA8gHpn3NZYR ck6w== X-Gm-Message-State: AOAM532btieDmoDCzyCzFpKH7f9jPzCjxY8yS17VYx2VpRihxgAyrLi3 8EJ8+BgNaEOCf1s6aQWKPXBV01422sD1NTx2PNg= X-Received: by 2002:a17:90a:be11:: with SMTP id a17mr3907925pjs.181.1603972323962; Thu, 29 Oct 2020 04:52:03 -0700 (PDT) MIME-Version: 1.0 References: <1603972048-64271-1-git-send-email-zou_wei@huawei.com> In-Reply-To: <1603972048-64271-1-git-send-email-zou_wei@huawei.com> From: Andy Shevchenko Date: Thu, 29 Oct 2020 13:52:53 +0200 Message-ID: Subject: Re: [PATCH -next] platform/surface: remove status assignment without reading To: Zou Wei Cc: Hans de Goede , Mark Gross , Maximilian Luz , Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 1:36 PM Zou Wei wrote: > > The status local variable is assigned but never read: ... > mutex_lock(&s3_wmi_lock); > - status = wmi_query_block(guid, instance, &output); What are you doing?! -- With Best Regards, Andy Shevchenko