Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp429190pxx; Thu, 29 Oct 2020 06:07:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+E8+Tf277l7d4oVF7HecUjPERigoqflhg0MqyAKUSnCJolQt3cSOqE88I2cP4m/J4RLXI X-Received: by 2002:a1c:1d92:: with SMTP id d140mr4354981wmd.48.1603976848326; Thu, 29 Oct 2020 06:07:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603976848; cv=none; d=google.com; s=arc-20160816; b=ou20gSMRf9EjU/YsR3Kwi3wxTkuvon12JR8mI6aiC9P8lPF6JU1gfap7ddY6081xOq YeM1ZWy/Yw4NugNT+SfV1UIupp1w/NohheOhSgGjpCCvWjhRACRYyigvqKjzjOLA46m/ 3EcuLtk/lq7s66lG7c5IACvWHsMyQsyAi2vhfryFqMmHtK37gtHqpBZF2/fSSVvS5f8A 1gc6ep+FfafOU/F6YB12BBL59eVWYXd3DFK4/sgHz87cawOinEO92kaNGSCeaUCwfjr4 f57hOLppsENkoqj6s9tSPAV7HqJTtZ8deBzxP/ZiwGBIBeBb7o1SeVapRxKYy+SpQo4w IbnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:sender:dkim-signature; bh=Td0XnDB5MGUyyHW6+aBIO4HGx6/p3E+sTiAeOAor+5o=; b=hK1fh/XgyMgGrBMH62ICYtgdRwk7n43RoYpNaaoVKwIWPBF/sPyZVzlez4F1yDUdp+ yW2LsNjNnp0o20FbmsS44SbYeBxhvB8cfB9yotCjuHOcifZ3y32P8KANiUjaeyEWvXs3 V5CwJcPlAZkgQ5twFMwOzWo4qsVzz3X5vu7X39m3Q+YMkcx2knWJaL6EswYp3kYE0glQ emjU5FYCUPF8hONuTygl9B0f29WsDyeoQvSmUFFjB6G5AtpChyVyzSCOxf11TCbj9v5i BoTaRSfNoaNLg+/bupZhH7BCM6i016u3WSRR6CkvosmhNlq1tMopWaWv6ZBDjwm61HjD xE2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=q9+cCJ40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lf14si1738262ejb.720.2020.10.29.06.06.56; Thu, 29 Oct 2020 06:07:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=q9+cCJ40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726696AbgJ2NDw (ORCPT + 99 others); Thu, 29 Oct 2020 09:03:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbgJ2NDv (ORCPT ); Thu, 29 Oct 2020 09:03:51 -0400 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E3EAC0613CF; Thu, 29 Oct 2020 06:03:51 -0700 (PDT) Received: by mail-oi1-x242.google.com with SMTP id 9so3087038oir.5; Thu, 29 Oct 2020 06:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Td0XnDB5MGUyyHW6+aBIO4HGx6/p3E+sTiAeOAor+5o=; b=q9+cCJ40rDzNAzVlRCYa3Inxo9dV/7bx1eH5RmRluPmy1Sy3gIHMf7xDWfk4hL3VDH 1Pl0PBwyyj7q4NqxYZ/o3cgiPEbd7Ln2rt6oa02JI/IMrnVMDQxzPqfuZwiJ7raLgnYG L5PDpHIV/DZyG/b6m0M/sgt5+SxdlpbhSdjZmmlXN1YfQft483ibryAqGYxWARg3t7Oz f22fgwWm1zS12gyoFWdVc1IOoUhS3Ex3VGPMe135KP8LfuLbeAvFLtF8dgC8mtKyTX1L p7o+oEJi5DW06vBsfoi/OOeBCEajuRLEFztNLXnBRzCgxZJXj9HNHEsjycMeui6+0XZf R0hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Td0XnDB5MGUyyHW6+aBIO4HGx6/p3E+sTiAeOAor+5o=; b=QcPGyJCO/aG32vDL0Ri+NPktH4NCu2Yc8oq3Tt3r8LHHyVpt7M+ZrnQs0dsY8pNhC1 rjAdUTscr9s7jQ4rOUkLxsKXQfDiZ/5aRjz8z17SMn8n+7R4xTrNySdLZujhTw7PabhW GVlhQFdJX6clbL9oxCZGJCsSvlAdwLzpOH6R5gaY0+ONhTd1NghHpTAl3qDi5kcvrZRP pQPMrS8aXGYcqqcJe3cAnYq4meUCzDPCXdqu+0+QBpvD2gwdbQTn5Cui1RnDrfYet8hm TNg38nqbswhfUs21s5RIb+ilF4w0EY8/QrwlZAtjQJtLpgMgQEuNQ4g1GBsMQScd1RPA PL3w== X-Gm-Message-State: AOAM533B/a4G+acoD/VjOyqthYxoRcd5BqFX0weuK4r9CbN6RxxMhxyg B4iVwGTy70LPYPM4g/cHXgByf3H+Klw= X-Received: by 2002:aca:31ce:: with SMTP id x197mr1925560oix.90.1603976630390; Thu, 29 Oct 2020 06:03:50 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id t75sm104063oif.25.2020.10.29.06.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 06:03:49 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH 2/3] watchdog: st_lpc_wdt: remove unnecessary CONFIG_PM_SLEEP To: Coiby Xu , Wim Van Sebroeck Cc: Patrice Chotard , "moderated list:ARM/STI ARCHITECTURE" , "open list:WATCHDOG DEVICE DRIVERS" , open list References: <20201029075327.228570-1-coiby.xu@gmail.com> <20201029075327.228570-2-coiby.xu@gmail.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: Date: Thu, 29 Oct 2020 06:03:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201029075327.228570-2-coiby.xu@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/20 12:53 AM, Coiby Xu wrote: > SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu > --- > drivers/watchdog/st_lpc_wdt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c > index 14ab6559c748..c1428d63dc9e 100644 > --- a/drivers/watchdog/st_lpc_wdt.c > +++ b/drivers/watchdog/st_lpc_wdt.c > @@ -248,7 +248,6 @@ static int st_wdog_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int st_wdog_suspend(struct device *dev) Again, this requires __maybe_unused. > { > struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev); > @@ -285,7 +284,6 @@ static int st_wdog_resume(struct device *dev) > > return 0; > } > -#endif > > static SIMPLE_DEV_PM_OPS(st_wdog_pm_ops, > st_wdog_suspend, >