Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp515194pxx; Thu, 29 Oct 2020 08:00:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2Fq1Sfd6vyuvenaYILg365pB6dXKmGHDB1vmoyP3MXm1d6sF8OnuZKYPqACXIBcy9u5X1 X-Received: by 2002:a17:906:4b0f:: with SMTP id y15mr4299699eju.198.1603983603282; Thu, 29 Oct 2020 08:00:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603983603; cv=none; d=google.com; s=arc-20160816; b=ZXaZkJexP2CL8XGplQjmtFnJ+bCgE2zrrBEOttU5pXYoXCgsBnDNBn3Thol8JyM2eF vNHz9yLN7W0RymWXtwsju9HTnZ3nPHBkrL6dANN1CCcf1uGF4xcL9VfL/dcCAbabty93 DTzqHGF1KrUFrRFrspE0SVjxC/wJ7BIDmn3jlTTvta1blZOABMJ8iz4FkPYZpA16jrNA Ts1YpmGx0OkDVy/xZb2nbvQO6EYL4uRrfg91Kz2jN0lKsSpgwr5/G/nxjBNid0F473Pi r73S1Equ4l0jdC9mR7yehjcN8Ycyj2e4E6XNZG4cG9tcd4aPZIeOPClMAuH4azhUP09L 0/cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gaixN9Bvdo5h62VzxGq1fbBr5CvrRZrgy2xdLXcGzLE=; b=mhQMTqMS5kg+I7A/13CxeHFVCm7gs024v8R/Fs3Alq8pqPX/r7rorKwEvH3TGBLFWd oQyV5wiQV7+IUe2nr33Gfi9hFrqhz4sbwa5YHK6gF9liwWoUOiZHCld63sqlVM0ic1Tb sGWQbtFgBtXxN15+JOOzDnoZwpc3+lMKV2bwoPaSrfNid871n3YpjYQVtieRhJPFSrWy /cfuedSqE1xQ81Rjk5elx18IJFdxoIiKZXPFefubHO+TVifttyJuJMclSj7ix1bxcZmJ CAZADZJH205RDkNWIlHhTUOO8BH1gY6nqwDf7luvGwJRRrI7ygJPJUFUV2mQqwLyLMQl 6DBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=bTYuNixG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h3si1933600ejy.603.2020.10.29.07.59.40; Thu, 29 Oct 2020 08:00:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=bTYuNixG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727836AbgJ2O5r (ORCPT + 99 others); Thu, 29 Oct 2020 10:57:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbgJ2O5r (ORCPT ); Thu, 29 Oct 2020 10:57:47 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 565CAC0613CF; Thu, 29 Oct 2020 07:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gaixN9Bvdo5h62VzxGq1fbBr5CvrRZrgy2xdLXcGzLE=; b=bTYuNixGSW2EZao7BIhpVMoBkg Fnfsb0miEeUi3RCG985nAhHBTRXcZ5zUyXS69dio+GuELyGkENctUrl4Si3aPWCXxI9R681ZfZjUb FfnzHqlfL6psaiXl1i+23BNkSEYxmg9iFWriVvp4QfG3iorYGmwxddxjuoFqNQg8LkBZ20KWgGzCR 3VPByv+8ikppMJVye3Zvksowg+Q87VfPAephQ4TPxKsSRUGsqEvKk1gLB+rt2laTKdVPwKewgXJQQ YCe4CkT2Bs/wAVsrqwBh/Cz6SUFnogZTvBB+LW6NHCdfQhfTtoDN4CdsdkGj82up76AVXl5Jlzpld rE/iUJJg==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY9N2-00056S-3U; Thu, 29 Oct 2020 14:57:44 +0000 Date: Thu, 29 Oct 2020 14:57:43 +0000 From: Christoph Hellwig To: Sebastian Andrzej Siewior Cc: Christoph Hellwig , linux-block@vger.kernel.org, Thomas Gleixner , David Runge , linux-rt-users@vger.kernel.org, Jens Axboe , linux-kernel@vger.kernel.org, Peter Zijlstra , Daniel Wagner , Mike Galbraith , Sagi Grimberg Subject: Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done Message-ID: <20201029145743.GA19379@infradead.org> References: <20201028065616.GA24449@infradead.org> <20201028141251.3608598-1-bigeasy@linutronix.de> <20201028141251.3608598-3-bigeasy@linutronix.de> <20201029131212.dsulzvsb6pahahbs@linutronix.de> <20201029140536.GA6376@infradead.org> <20201029145623.3zry7o6nh6ks5tjj@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029145623.3zry7o6nh6ks5tjj@linutronix.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 03:56:23PM +0100, Sebastian Andrzej Siewior wrote: > On 2020-10-29 14:05:36 [+0000], Christoph Hellwig wrote: > > Well, usb-storage obviously seems to do it, and the block layer > > does not prohibit it. > > Also loop, nvme-tcp and then I stopped looking. > Any objections about adding local_bh_disable() around it? To me it seems like the whole IPI plus potentially softirq dance is a little pointless when completing from process context. Sagi, any opinion on that from the nvme-tcp POV?