Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750973AbWHPNjT (ORCPT ); Wed, 16 Aug 2006 09:39:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751077AbWHPNjT (ORCPT ); Wed, 16 Aug 2006 09:39:19 -0400 Received: from relay.2ka.mipt.ru ([194.85.82.65]:34471 "EHLO 2ka.mipt.ru") by vger.kernel.org with ESMTP id S1750973AbWHPNjS (ORCPT ); Wed, 16 Aug 2006 09:39:18 -0400 Date: Wed, 16 Aug 2006 17:38:40 +0400 From: Evgeniy Polyakov To: Christoph Hellwig Cc: lkml , David Miller , Ulrich Drepper , Andrew Morton , netdev , Zach Brown Subject: Re: [take9 0/2] kevent: Generic event handling mechanism. Message-ID: <20060816133840.GA4314@2ka.mipt.ru> References: <20060731103322.GA1898@2ka.mipt.ru> <11555364962921@2ka.mipt.ru> <20060816132631.GA32499@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060816132631.GA32499@infradead.org> User-Agent: Mutt/1.5.9i X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.7.5 (2ka.mipt.ru [0.0.0.0]); Wed, 16 Aug 2006 17:38:42 +0400 (MSD) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 38 On Wed, Aug 16, 2006 at 02:26:31PM +0100, Christoph Hellwig (hch@infradead.org) wrote: > On Mon, Aug 14, 2006 at 10:21:36AM +0400, Evgeniy Polyakov wrote: > > > > Generic event handling mechanism. > > Hi, I've just started looking into this, so some comments here first > on the submission process: > > - could you send new revisions of the patches in a new thread so one can > easily find them? Ok. > - the patch split is not very nice, your first patch adds Makefile and > Kconfig entries for files only in the second patch or not actually > submitted at all, that's a big no-no. It is done by scripts using list of files generated by git-diff, but I can reformat them to be in a way: core files poll/select timer any other main Kconfig/Makefile Kevent's makefile still contains all entries for files added later, is it a big problem right now? I can split patches manually, but it would be much better to do it when decision about it's inclusion is made, and until review and feature addiotion process is not completed generate patches as is... -- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/