Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201029002827.1729915-1-evgreen@chromium.org>
 <20201028172737.v3.3.Ibb3eedcd634298b039e3af2ec43c7860ae947916@changeid> <c244ed8a-ccd4-6e7d-501c-e3d7f2da3916@linaro.org>
In-Reply-To: <c244ed8a-ccd4-6e7d-501c-e3d7f2da3916@linaro.org>
From:   Evan Green <evgreen@chromium.org>
Date:   Thu, 29 Oct 2020 09:17:59 -0700
Message-ID: <CAE=gft6aAUdzB5rPDu4E33Pt_8Q=LcB++zmQdnpiyXbqW3Mhyg@mail.gmail.com>
Subject: Re: [PATCH v3 3/4] nvmem: core: Add support for keepout regions
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Douglas Anderson <dianders@chromium.org>,
        Stephen Boyd <swboyd@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 29, 2020 at 5:08 AM Srinivas Kandagatla
<srinivas.kandagatla@linaro.org> wrote:
>
> Thanks Evan for doing this,
>
> On 29/10/2020 00:28, Evan Green wrote:
> > Introduce support into the nvmem core for arrays of register ranges
> > that should not result in actual device access. For these regions a
> > constant byte (repeated) is returned instead on read, and writes are
> > quietly ignored and returned as successful.
> >
> > This is useful for instance if certain efuse regions are protected
> > from access by Linux because they contain secret info to another part
> > of the system (like an integrated modem).
> >
> > Signed-off-by: Evan Green <evgreen@chromium.org>
>
> Overall the patch looks good for me.
> I have applied just this patch for more testing in next!
>
> I can pick up 1/4 and 4/4 once Rob's Ack/Reviews the patch!

Thank you, Srini!
-Evan