Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp589258pxx; Thu, 29 Oct 2020 09:34:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkp3L3tveEDup46806s9HIgEbxW4UjiSCkZ5RoWJdx38c5mSfjye1qiQ0lJ3qXiq3pynl3 X-Received: by 2002:aa7:c2d9:: with SMTP id m25mr5027676edp.226.1603989293536; Thu, 29 Oct 2020 09:34:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603989293; cv=none; d=google.com; s=arc-20160816; b=0Q9ZDTVN6opx7T9aK7SeCMQmxY1/s2e+xfOy82oWDJCS0ExL/wa0Fu4q8LHhoJHy5Z K0bzZD7iQ1eINbgABBWChxCv1Md8bn6mYGLlln+n36D4gVe8ygHcWM/o3PVECUbxBKVI BRbrxKfhzqi7iyfZJdARZKJXIdGTCJgGA2pH8SuB7o0Q/tipSYcdmJubW409Kv/+Ex7b Uflb6G05HN7TTnLN3xRsOzWJTmg7NaKiXlgugt/koZXKBCMdDKNAKJoSjwZnTm1NfMwT fRX36Dh9cYT8fwlMhBALr1Qbk3cM1g8QN0CrQ0M1q50N4M9OnapcGxdc+uC72rdVCE83 FlNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RQfiQHQgHS05gLEzqVB6Cx3Kq3EwozclMZoPoxYZpQo=; b=g1Dxvo7avlOS1OcoEW5nMn/CEEWvIy397UZmwUQIyjbPPQOn6DErxyRawDH6oTrzC1 gmbDx/k05GAIi41mTgNAWmGUu/yYREkOfIha1zQysjg7HVl0CrQqSN0W3Scia4MX8Hfn GUxLShuuXUfOwp6KjX0FONCVmqpY8zvIb0PrXs8zE4DQv5lrXcZiqNBq4vREfYYHF+xP 6YnGAUvadbIRZTYXlPP88oahSRgyZ+pIxZJehBMlBuHhKCSWnSAdJ6SWett7uYA/UBr0 sil8R7/NgJ3P6Rn48jvdOwsgE9t8rpvvq1hvV/sXdNcyjjLdMfIR8Wm5KAbenudTDJLb qVww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si2132144eju.470.2020.10.29.09.34.30; Thu, 29 Oct 2020 09:34:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726980AbgJ2QcL (ORCPT + 99 others); Thu, 29 Oct 2020 12:32:11 -0400 Received: from netrider.rowland.org ([192.131.102.5]:46127 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726845AbgJ2QaP (ORCPT ); Thu, 29 Oct 2020 12:30:15 -0400 Received: (qmail 1330944 invoked by uid 1000); 29 Oct 2020 12:30:14 -0400 Date: Thu, 29 Oct 2020 12:30:14 -0400 From: Alan Stern To: Anant Thazhemadam Cc: Oliver Neukum , "David S . Miller" , Jakub Kicinski , netdev , linux-usb@vger.kernel.org, LKML , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v2] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API Message-ID: <20201029163014.GC1324094@rowland.harvard.edu> References: <20201010065623.10189-1-anant.thazhemadam@gmail.com> <20201029132256.11793-1-anant.thazhemadam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 08:46:59PM +0530, Anant Thazhemadam wrote: > I had a v2 prepared and ready but was told to wait for a week before sending it in, > since usb_control_msg_{send|recv}() that were being used were not present in the > networking tree at the time, and all the trees would be?converged by then. > So, just to be on the safer side, I waited for two weeks. > I checked the net tree, and found the APIs there too (defined in usb.h). > > However the build seems to fail here, > ??? https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/O2BERGN7SYYC6LNOOKNUGPS2IJLDWYT7/ > > I'm not entirely sure at this point why this is happening, and would appreciate it if > someone could take the time to tell me if and how this might be an issue with my > patch. It's happening because the tree you used for building did not include the declarations of usb_control_msg_{send|recv}(). It's hard to tell exactly what that tree does contain, because the github.com links embedded in the web page you mention above don't work. Alan Stern