Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp667950pxx; Thu, 29 Oct 2020 11:27:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwCwAC/8oKLJ7VkVOjDD9qmGCNQISRHaS+X60OwgIPhPaIgdD3iAXS+G+gWCAuKAaTw1sp X-Received: by 2002:a17:906:39ce:: with SMTP id i14mr5592142eje.170.1603996079404; Thu, 29 Oct 2020 11:27:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603996079; cv=none; d=google.com; s=arc-20160816; b=pvK13i0mMV0994oSYmkpIAof6g9LFUzdLur0c/YmD4QA1lojPpRenhMd7SHytPU8m+ gjVaUm4vJnyxlNfWnVPsOM/XrdQiutZ0Qe6QGi37DJR3QHXfGj0bQ4xuP0xlRmXfhKTb aeBwu4OEpEO79gUdmAJe8S2DkeL6QWuvtPP91kltInLycIrBQQQY/gsu8XbFw7DOBMTa zjReVCPVFTRZTsSco89C8iYol+zCOFmTwyoInRU+G4TUXD5BbmMfFw8CQUqZG1q5kSnQ ldylsIszDdBZpVIjCCOHV1RrycnWQf2JGsOusZLMntvYAS0/OgEwJjGCrotGuSrfB6lp 6Gfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=UwHb92aStmpwaRizYI024z1yovPnAy9wwMkBQ8yGS2Q=; b=Bbyc4bfNLEJW2egzDPgCy+x9gH8d0HTFwH905pzU1+GirG+pzdyc+Bagnmh01yXJOk y0KY1XHiYvhQIaJ6MxUVkYIgVC0Y4SUYQaxVIWSXTywImBSmsRkLxsCBg1WaYJ/8AqHX J1qVA3FFliCQsg0pOPCmEKmmkqJF2FoNEqxGbjqnHe0nm6yyAJvsEoocOO4jIM0PyrLb 5O1S230hmoQ1FzuIj1pSc+ScpbANcF/aMeKpKBhvLH+ZrJr6iwXInlm8C29Lx/xkPws/ jtPQPigX9x476GFDj7SrAM+CurCr+SCO5IdqOBNH6fqaIsD/YOH+84Tf0tZbBP1DyA+a BCtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nic.cz Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si2539886edy.58.2020.10.29.11.27.37; Thu, 29 Oct 2020 11:27:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nic.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbgJ2S0E (ORCPT + 99 others); Thu, 29 Oct 2020 14:26:04 -0400 Received: from mail.nic.cz ([217.31.204.67]:35660 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725785AbgJ2S0E (ORCPT ); Thu, 29 Oct 2020 14:26:04 -0400 Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id 5947B140835; Thu, 29 Oct 2020 19:26:02 +0100 (CET) Date: Thu, 29 Oct 2020 19:25:55 +0100 From: Marek Behun To: Pavel Machek Cc: Yu Kuai , linus.walleij@linaro.org, j.anaszewski@samsung.com, simon.guinot@sequanux.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH] leds: various: add missing put_device() call in netxbig_leds_get_of_pdata() Message-ID: <20201029192555.36834608@nic.cz> In-Reply-To: <20201029174952.GB26053@duo.ucw.cz> References: <20201029092305.900767-1-yukuai3@huawei.com> <20201029174952.GB26053@duo.ucw.cz> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-100.0 required=5.9 tests=SHORTCIRCUIT,URIBL_BLOCKED, USER_IN_WELCOMELIST,USER_IN_WHITELIST shortcircuit=ham autolearn=disabled version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.nic.cz X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Oct 2020 18:49:52 +0100 Pavel Machek wrote: > > Thanks, applied. > > But it seems to me similar handling is needed in "success" paths, no? > > Best regards, > Pavel Pavel, the subject of this commit is wrong. It should begin with leds: netxbig: instead of leds: various: since the patch does not touch various drivers, only one: netxbig. Marek