Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp675416pxx; Thu, 29 Oct 2020 11:40:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZ/2kgl1XfMCqq9EKefXNUEp1ls4Au15z4aO0uJ9AGid7y+iWGf1Om0HtRe/qJq3WxHdet X-Received: by 2002:a50:dac1:: with SMTP id s1mr5522837edj.74.1603996807593; Thu, 29 Oct 2020 11:40:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603996807; cv=none; d=google.com; s=arc-20160816; b=ILzgyYNwUfWIBmUqBTrJZvi4fZ5kfM4Mrt74zWUJTXDwQOrBKvk0l1o/zjG8Bx2Vdj XmK/3ZQIC1Qri8/EM6g3Rr9OklzZhNif65u6XmQUue4Pcta0IctXAS62c748hSvoeZHV e/yQO5X/QfzNETO2kqdRJwi26KHE7nUufxw2GfEblv3rkA528jkO7htZoQzu5ypuhd7+ Q9oGf45KtfP88rS/z98GCw5pnMmu2DkpNIjTQNPO4ucW9R19gUbdRz1ibLakBsjPV7ff +DkzfokofkrnAORRpBOR5cgdXI44cPPf7edZvZ91Z/WQsyKxwATQy1IF1mbsg1xJzJAG f/LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=lTgq2KUsCb/reJLVeXMJ6WnOU7EAbYhrVIOVottwPXY=; b=0to6wE9ASwL7Z0p5ZfYw0tw8x6XkR5+6sCRJ27QZFV37k6ufj0Wz6XB4blx0/RpPd4 +eLdwWJUIBIycFW5zzAjDrwF4ZwE3G//F5FSbQFtwEeLXJDgUSndHKv2fjQi2XrqovVL DIwzgkeEjRnFmStnObSzHEsbD+GOsRgPiyiInMoJMhAYXyj3s95r9smpIRa7XRt3d0gl 9amX8hk6dgu6QIOfKXqOz8mRnohm6deSg+w0yiaPYsBDNDzVX2jKsOn6HjXAWdrdhT4T BZQiLUjwa6Pd1ESaXUcVzmHbFd5vQQGPXqN9WiGUwQqiiae8LO43PPQFTl7XmijnJ6BB ikFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i25si2296997ejd.567.2020.10.29.11.39.42; Thu, 29 Oct 2020 11:40:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725824AbgJ2Sg4 (ORCPT + 99 others); Thu, 29 Oct 2020 14:36:56 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:37233 "EHLO mail-ej1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgJ2Sgz (ORCPT ); Thu, 29 Oct 2020 14:36:55 -0400 Received: by mail-ej1-f65.google.com with SMTP id p9so5215729eji.4 for ; Thu, 29 Oct 2020 11:36:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lTgq2KUsCb/reJLVeXMJ6WnOU7EAbYhrVIOVottwPXY=; b=TH+qHdzmjQcCaNi1yyBSx6HJoQKktWZBFVLcaH/rzYr9TdsJALPFN0xAaahb0sdzwZ V6RKZo/qzM7/ACOFjSfvAuXnsyd/7JoUB72CX3xdznf9f+AvTMsJr9uJAzou9yxEcmOF GwlCct6aIx/mvx2xi5ECsPwfRU1OoVw332PtPoDNl9ZdLd105JkLVbk2VVIHYuMHKr4B FFtdRGYtCZO5RNeLXzvjvet3oF7DUaBQrd1RYRjj+iuJWbXrCYTPRYRhdkEBvsko56r6 /CUIhtd+HQC7uTgoNg6BqpDSu2S4rUR8K4NV2USZwGe1mFRkGYk03WAXo/Y+lJ7YjIZE kgGA== X-Gm-Message-State: AOAM530uj2S0Wlkk80rqY2SosDj5es/KonHBg1ot3TpsIWcYIhDyeFFC GP/IkCsh3hOoQMCw5Jx0mh72EPRwkACT2A== X-Received: by 2002:a17:906:3daa:: with SMTP id y10mr5377897ejh.23.1603996614181; Thu, 29 Oct 2020 11:36:54 -0700 (PDT) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id w25sm1888481ejy.123.2020.10.29.11.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 11:36:52 -0700 (PDT) Date: Thu, 29 Oct 2020 19:36:51 +0100 From: Krzysztof Kozlowski To: Xu Wang Cc: sbkim73@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: samsung: i2s: Remove redundant null check before clk_disable_unprepare Message-ID: <20201029183651.GA90952@kozik-lap> References: <20201029083715.28561-1-vulab@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201029083715.28561-1-vulab@iscas.ac.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 08:37:15AM +0000, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. You missed other places with it - the resume part. Best regards, Krzysztof > > Signed-off-by: Xu Wang > --- > sound/soc/samsung/i2s.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)