Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Oct 2020 14:32:40 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Willy Liu <willy.liu@realtek.com>
Cc:     <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: realtek: Add phy ids for
 RTL8226-CG/RTL8226B-CG
Message-ID: <20201029143240.5b21e1ca@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <1603973277-1634-1-git-send-email-willy.liu@realtek.com>
References: <1603973277-1634-1-git-send-email-willy.liu@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 29 Oct 2020 20:07:57 +0800 Willy Liu wrote:
> Realtek single-port 2.5Gbps Ethernet PHY ids as below:
> RTL8226-CG: 0x001cc800(ES)/0x001cc838(MP)
> RTL8226B-CG/RTL8221B-CG: 0x001cc840(ES)/0x001cc848(MP)
> ES: engineer sample
> MP: mass production
>=20
> Since above PHYs are already in mass production stage,
> mass production id should be added.
>=20
> Signed-off-by: Willy Liu <willy.liu@realtek.com>

drivers/net/phy/realtek.c: In function =E2=80=98rtl8226_match_phy_device=E2=
=80=99:
drivers/net/phy/realtek.c:540:47: warning: suggest parentheses around =E2=
=80=98&&=E2=80=99 within =E2=80=98||=E2=80=99 [-Wparentheses]
  540 |         (phydev->phy_id =3D=3D RTL_8226_MP_PHYID) &&
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
  541 |         rtlgen_supports_2_5gbps(phydev);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~     =20