Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 33/33] docs: ABI: unify
 /sys/class/leds/<led>/max_brightness documentation
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Jonathan Corbet <corbet@lwn.net>, Dan Murphy <dmurphy@ti.com>,
        Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org
References: <cover.1603893146.git.mchehab+huawei@kernel.org>
 <2c95a4d8d1b4be2f839464ebc63bfcee6b70276a.1603893146.git.mchehab+huawei@kernel.org>
From:   Jacek Anaszewski <jacek.anaszewski@gmail.com>
Message-ID: <514e13de-b6f6-1df1-ddfe-5a1a2ca8fb87@gmail.com>
Date:   Thu, 29 Oct 2020 23:11:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <2c95a4d8d1b4be2f839464ebc63bfcee6b70276a.1603893146.git.mchehab+huawei@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Mauro,

Patch title needs fixing:

s/max_brightness/brightness/

On 10/28/20 3:23 PM, Mauro Carvalho Chehab wrote:
> This ABI is defined twice, one for normal leds and another
> one for multicolor ones.
> 
> Ensure that just one definition is there at ABI.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>   Documentation/ABI/testing/sysfs-class-led     | 25 ++++++++++++++++---
>   .../ABI/testing/sysfs-class-led-multicolor    | 23 +++++------------
>   2 files changed, 28 insertions(+), 20 deletions(-)
> 
[...]
> +
>   What:		/sys/class/leds/<led>/max_brightness
>   Date:		March 2006
>   KernelVersion:	2.6.17
> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor b/Documentation/ABI/testing/sysfs-class-led-multicolor
> index eeeddcbdbbe3..16fc827b10cb 100644
> --- a/Documentation/ABI/testing/sysfs-class-led-multicolor
> +++ b/Documentation/ABI/testing/sysfs-class-led-multicolor
> @@ -1,20 +1,3 @@
> -What:		/sys/class/leds/<led>/brightness
> -Date:		March 2020
> -KernelVersion:	5.9
> -Contact:	Dan Murphy <dmurphy@ti.com>
> -Description:	read/write
> -		Writing to this file will update all LEDs within the group to a
> -		calculated percentage of what each color LED intensity is set
> -		to. The percentage is calculated for each grouped LED via the
> -		equation below:


-- 
Best regards,
Jacek Anaszewski