Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Oct 2020 15:11:54 -0700
From:   Prashant Malani <pmalani@chromium.org>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 7/7] platform/chrome: cros_ec_typec: Register partner
 altmodes
Message-ID: <20201029221154.GB3913249@google.com>
References: <20201021205317.708008-1-pmalani@chromium.org>
 <20201021205317.708008-8-pmalani@chromium.org>
 <20201028131732.GB2026875@kuha.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201028131732.GB2026875@kuha.fi.intel.com>
Precedence: bulk

Hi Heikki,

Thank you for reviewing the patch!

On Wed, Oct 28, 2020 at 03:17:32PM +0200, Heikki Krogerus wrote:
> Hi,
> 
> On Wed, Oct 21, 2020 at 01:53:16PM -0700, Prashant Malani wrote:
> > +static void cros_typec_unregister_altmodes(struct cros_typec_data *typec, int port_num)
> > +{
> > +	struct cros_typec_port *port = typec->ports[port_num];
> > +	struct cros_typec_altmode_node *node;
> > +
> > +	while (!list_empty(&port->partner_mode_list)) {
> > +		node = list_first_entry(&port->partner_mode_list, struct cros_typec_altmode_node,
> > +					list);
> 
>         ...
>         struct cros_typec_altmode_node *node, *tmp;
> 
>         list_for_each_entry_safe(node, tmp, &port->partner_mode_list, list) {
> 

Nice; I will make this update in v2. Thanks!

Best regards,

-Prashant