Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp913323pxx; Thu, 29 Oct 2020 18:30:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5eAgsg8UCRUnsnN2ZvjUgfPd1yYDxAj2hLwSOb7iaOPWkq4GKZc2CU4jFX+X2WwqfcZX3 X-Received: by 2002:a17:906:7481:: with SMTP id e1mr144269ejl.13.1604021420167; Thu, 29 Oct 2020 18:30:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604021420; cv=none; d=google.com; s=arc-20160816; b=rDnYHTi0bsIF1528Jwod4YHh1B5Io//Wkk39yHnpZhUS/X2CASAuxdAwByy2o23X3S Ow1L12SPFZ3/9cW8O91BJR2BrgYTYg1IMb2yz9DXJpjfq4g1d4ud6mvzDymK3tu4t6X5 be0AJjYjsdXTpPmH4XSN23Bi6d0r07bosUeD2TZlgJhznxy5XfBZ6oR2z/fB2Yc9TRbE NZYC2EnKabBfoxUmuIvjnHBruK1mj9SUh9jqwodwrWFv2FtCm7gv0pEnLCUmBClDrMNl v1tMbPr0fQQp5QLuazds/aeZ2BXZtUhq88M41rxVxOQcvOwiWsfqwQthV1+cjxsEOrby s1Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:to:from; bh=M/8iEbR2lrOfcYHj3UhZP0mxKcp3aoYnbSsT0NBHavk=; b=eJnkq6YAs2dHxe366k3IlkfOkboK5jLbr3fCneiXeNdNBo1WFpoRMffvyDM4HX4Fto YYVlpSGLV5cZmAtcfXSvKAQ1iLxP1TOvMll61nkEBDFq36oP2sKMzD/fukH1Z9a8uWpm +aIkjiE/J6e9Hg2sL4D2AQQgWIUyHn6Np3gICQBY/R+vaywhhLCLus+2bwC9ofRJXs3K uGNxavS9PugtPKNoYh8dhx48hZR2KNLJlIZOSSnbY0cSFkXXc9nH0PPDYgshPgCRB7Tx 6Pzb6bLmb4gIHerfp4pcirJR7q5yyvos5RYjCzOgE76IgZ9yIv/nsmCPseIJd8btr2zZ 8ekw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r8si3779906edw.268.2020.10.29.18.29.58; Thu, 29 Oct 2020 18:30:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726117AbgJ3B2J (ORCPT + 99 others); Thu, 29 Oct 2020 21:28:09 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7009 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbgJ3B2I (ORCPT ); Thu, 29 Oct 2020 21:28:08 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CMl7D23Q5zhctk; Fri, 30 Oct 2020 09:28:08 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Fri, 30 Oct 2020 09:28:00 +0800 From: Tian Tao To: , , Subject: [PATCH] mmc: moxart: replace spin_lock_irqsave by spin_lock in hard IRQ Date: Fri, 30 Oct 2020 09:28:39 +0800 Message-ID: <1604021319-31338-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao --- drivers/mmc/host/moxart-mmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c index f25079b..89bff4e 100644 --- a/drivers/mmc/host/moxart-mmc.c +++ b/drivers/mmc/host/moxart-mmc.c @@ -465,9 +465,8 @@ static irqreturn_t moxart_irq(int irq, void *devid) { struct moxart_host *host = (struct moxart_host *)devid; u32 status; - unsigned long flags; - spin_lock_irqsave(&host->lock, flags); + spin_lock(&host->lock); status = readl(host->base + REG_STATUS); if (status & CARD_CHANGE) { @@ -484,7 +483,7 @@ static irqreturn_t moxart_irq(int irq, void *devid) if (status & (FIFO_ORUN | FIFO_URUN) && host->mrq) moxart_transfer_pio(host); - spin_unlock_irqrestore(&host->lock, flags); + spin_unlock(&host->lock); return IRQ_HANDLED; } -- 2.7.4