Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp940437pxx; Thu, 29 Oct 2020 19:31:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAdZ2kk5Ix2PAxS6x7lWj/tM/MLzrvpGttt/dR+yANghzux47tVxIhNNj57XrrE3HBGOoL X-Received: by 2002:a17:906:a090:: with SMTP id q16mr346438ejy.220.1604025115886; Thu, 29 Oct 2020 19:31:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604025115; cv=none; d=google.com; s=arc-20160816; b=wK4pnVTxqh6NRdE+QH6S3oGiHpxSE+mIsCP8wXpOZjHAEdAou5UNz7exDp38Uc1/Wl Dfj2EgN2HoDfIZDZuLJ8oUe9e9ZGDfV9CAdsJ7uN2NWcR4GZkmjJdmjZej13uY44C5/0 JVvHxQiKuscESKm/Z3DQ03AoNGwHfAmcw0GBWOx4nnRiE1QTEZrJKcThHSnOjPK/2rqY mtsGxy/77Xaxj30P0hcr/0QEDnzouRWiHjSimybwXgXcLb6gjFPgz1EeMG/hwZoydFBZ lvGiBIphpNdMedkofK20oPSRcLMd2v8PDRJPa7gbmVUgj/nYV3rmjm2zGOsaTMU5MwtQ 7JGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=wUeAW+N0QrHya/gWMifu3ns2eXGWz0qWjaeekTOnJuo=; b=YLGcYTcDB0v+gC5KjGt4xHFcmC1UT1rs7m5CqmCN70jZi8rSg4y0WqI8He5osIh5w7 5H4+wCOhgiVkOHzcVEuTpWslMQaNMkPr/KCNX5VWRZOtxiciVhpXmuksSMDhFjqpqs8b PMVsBw1kagpsq6NYh/K3p11M5gHEOfYjsRIZ4rym/1mIbo8hl6tD9IkCWtzGorm7LyzB HloQ75Z8+XjpwTuRXkQDw0fH7ZwIXgCx7om7AYoEvSjZXvD+71zndPKZld8hXnQQ30cw vL2/fLMcwYec9ltaasAaAYgyOIR2Qyvam59M5n23N1eh2UKVrBCiWBhD0tNMNbwivmbS vZnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q14si3515849edv.127.2020.10.29.19.31.33; Thu, 29 Oct 2020 19:31:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726237AbgJ3CaE (ORCPT + 99 others); Thu, 29 Oct 2020 22:30:04 -0400 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:60283 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbgJ3CaD (ORCPT ); Thu, 29 Oct 2020 22:30:03 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0UDafu36_1604024997; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UDafu36_1604024997) by smtp.aliyun-inc.com(127.0.0.1); Fri, 30 Oct 2020 10:29:58 +0800 Subject: Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if memcg disabled To: Johannes Weiner Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Michal Hocko References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-3-git-send-email-alex.shi@linux.alibaba.com> <20201029134648.GC599825@cmpxchg.org> From: Alex Shi Message-ID: <96b6d122-df0e-dfb0-368c-6bd714fab116@linux.alibaba.com> Date: Fri, 30 Oct 2020 10:27:51 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201029134648.GC599825@cmpxchg.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2020/10/29 ????9:46, Johannes Weiner ะด??: >> ? release_pages+0x1ae/0x410 >> shmem_alloc_and_acct_page+0x77/0x1c0 >> shmem_getpage_gfp+0x162/0x910 >> shmem_fault+0x74/0x210 >> ? filemap_map_pages+0x29c/0x410 >> __do_fault+0x37/0x190 >> handle_mm_fault+0x120a/0x1770 >> exc_page_fault+0x251/0x450 >> ? asm_exc_page_fault+0x8/0x30 >> asm_exc_page_fault+0x1e/0x30 >> >> Signed-off-by: Alex Shi >> Reviewed-by: Roman Gushchin >> Acked-by: Michal Hocko >> Acked-by: Hugh Dickins >> Cc: Johannes Weiner >> Cc: Michal Hocko >> Cc: Vladimir Davydov >> Cc: Andrew Morton >> Cc: cgroups@vger.kernel.org >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org > Acked-by: Johannes Weiner > > This should go in before the previous patch that adds the WARN for it. Right, but than the long ops may not weird. Should I remove the ops and resend the whole patchset? Which way is convenient for you? Thanks Alex