Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [f2fs-dev] [PATCH v5 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION
 ioctl
From:   Chao Yu <yuchao0@huawei.com>
To:     Daeho Jeong <daeho43@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linux-f2fs-devel@lists.sourceforge.net>, <kernel-team@android.com>
CC:     Daeho Jeong <daehojeong@google.com>
References: <20201029041538.4165209-1-daeho43@gmail.com>
 <861e569d-feae-c521-35b7-dcb8b79cdfba@huawei.com>
Message-ID: <61d43f5d-f26c-525a-6405-bae0ca495c6d@huawei.com>
Date:   Fri, 30 Oct 2020 10:37:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <861e569d-feae-c521-35b7-dcb8b79cdfba@huawei.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020/10/29 15:24, Chao Yu wrote:
> On 2020/10/29 12:15, Daeho Jeong wrote:

>> +	inode_lock(inode);
> 
> It's minor,
> 
> inode_lock_shared()?
> 
>> +
>> +	if (!f2fs_compressed_file(inode)) {
>> +		inode_unlock(inode);
> 
> inode_unlock_shared()?
> 
>> +		return -ENODATA;
>> +	}
>> +
>> +	option.algorithm = F2FS_I(inode)->i_compress_algorithm;
>> +	option.log_cluster_size = F2FS_I(inode)->i_log_cluster_size;
>> +
>> +	inode_unlock(inode);
> 
> ditto.

Any comments?

Thanks,