Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201029041538.4165209-1-daeho43@gmail.com> <861e569d-feae-c521-35b7-dcb8b79cdfba@huawei.com>
 <61d43f5d-f26c-525a-6405-bae0ca495c6d@huawei.com>
In-Reply-To: <61d43f5d-f26c-525a-6405-bae0ca495c6d@huawei.com>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Fri, 30 Oct 2020 12:25:06 +0900
Message-ID: <CACOAw_xHM-FB3pRfFnjF-9eVgo=cxPh=tsLyEX30NHaz2gAbtQ@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH v5 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl
To:     Chao Yu <yuchao0@huawei.com>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Opps, I missed this.
We need v7... lol

2020=EB=85=84 10=EC=9B=94 30=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 11:37,=
 Chao Yu <yuchao0@huawei.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On 2020/10/29 15:24, Chao Yu wrote:
> > On 2020/10/29 12:15, Daeho Jeong wrote:
>
> >> +    inode_lock(inode);
> >
> > It's minor,
> >
> > inode_lock_shared()?
> >
> >> +
> >> +    if (!f2fs_compressed_file(inode)) {
> >> +            inode_unlock(inode);
> >
> > inode_unlock_shared()?
> >
> >> +            return -ENODATA;
> >> +    }
> >> +
> >> +    option.algorithm =3D F2FS_I(inode)->i_compress_algorithm;
> >> +    option.log_cluster_size =3D F2FS_I(inode)->i_log_cluster_size;
> >> +
> >> +    inode_unlock(inode);
> >
> > ditto.
>
> Any comments?
>
> Thanks,