Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201029100647.233361-1-coiby.xu@gmail.com> <20201029100647.233361-9-coiby.xu@gmail.com>
In-Reply-To: <20201029100647.233361-9-coiby.xu@gmail.com>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Fri, 30 Oct 2020 12:02:03 +0800
Message-ID: <CAAfSe-vv=EXzC4xjnF6RNO+ifoodYCui4cgdodNisQio0TLHtg@mail.gmail.com>
Subject: Re: [PATCH 9/9] mfd: sprd-sc27xx-spi: remove unnecessary CONFIG_PM_SLEEP
To:     Coiby Xu <coiby.xu@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>, Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Coiby,

After removing CONFIG_PM_SLEEP, sprd_pmic_suspend/resume() would not
be built into symbol table with clang compiler though, that would
cause clang compiler report warnings of "unused function" if
CONFIG_PM_SLEEP is not set. So I also prefer to add a __maybe_unused
instead as other people suggested in the mail list.

Thanks,
Chunyan


On Thu, 29 Oct 2020 at 18:07, Coiby Xu <coiby.xu@gmail.com> wrote:
>
> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. Signed-=
off-by: Coiby Xu <coiby.xu@gmail.com>  drivers/mfd/sprd-sc27xx-spi.c | 2 --=
  1 file changed, 2 deletions(-) diff --git a/drivers/mfd/sprd-sc27xx-spi.c=
 b/drivers/mfd/sprd-sc27xx-spi.c index 6b7956604a0f..4db2ec9ef2ff 100644 --=
- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -2=
06,7 +206,6 @@ static int sprd_pmic_probe(struct spi_device *spi) return 0;=
 -#ifdef CONFIG_PM_SLEEP  static int sprd_pmic_suspend(struct device *dev) =
struct sprd_pmic *ddata =3D dev_get_drvdata(dev); @@ -226,7 +225,6 @@ stati=
c int sprd_pmic_resume(struct device *dev) return 0; -#endif  static SIMPLE=
_DEV_PM_OPS(sprd_pmic_pm_ops, sprd_pmic_suspend, sprd_pmic_resume); 2.28.0