Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1097608pxx; Fri, 30 Oct 2020 01:48:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOqJcNKTHelrFN1BE11cfZHHguU2QypSMtLG+96eOaF7O3cGua1n1Qcx/EytK8bc+4Plep X-Received: by 2002:a17:906:4bc2:: with SMTP id x2mr1396270ejv.525.1604047688986; Fri, 30 Oct 2020 01:48:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604047688; cv=none; d=google.com; s=arc-20160816; b=ANKfw8YBMxl7b3BnQiXNMlh1r7c/wcavuaNb6IfszDsC+lDMT0rGDMWchRW0Cyunty ZknoCJS2Y1cy73MhbFfeGnWy6994Ue6O6D4fngKrT1+37LHBCcYMFZRikNVWXrNJUENG Y4koKhUMajW6KDwDKqBVzjkSsDrXeJJ9E12VtSJc0Nt92aj3AWCrZsg7akBMHxq/iEFt DX1LWiTUV9npIkiqPtGbQLlhs64DVicrEJld25dtTr+0M0TvgzMpbgVbBJ/KpvsZ4fJY vANgF9KjxNDPPh9SmV8mH1r7YT0WdbbruKbEA0b0cpLucssClDTkGUByD81dKmZYP7+u iNjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Zjy+X27aC3BhbWPv7QA/9gc3gSiVuiuPxPB3gkRInAE=; b=h6NIR4j4CQwQiCH+ugbnRAi8jB2Nv/8zBmGu4Ijxx9NpwA1QjccPkMz1gq8l27DvIO pcZCpYsvB0npB0Iy8UiKICfmhef1r3KYtFpG7qqwt9bRCpxk22lyA7LLxrBMD8rc0rEj SsYkFNzJ9GcqOVfAJMDHHrq7FpuQ/fUtO5ndk1KaBoygGNbPJLd4gArRQGldw2pKhFUO rPHXtEImT9ZoRWGIYWf64CMzP/N9AuJciLdhdj7yuN/C1Km0p4CYxx0HyDHue8dzEt0z ZklQ0tDprcMVz6cPQpjJiokhOb42G7eQhlkI/I8uE3boDU8XL4iTvfcJKTsdMRz37YOr uEHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jWsiaE+j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t6si3648478ejf.462.2020.10.30.01.47.46; Fri, 30 Oct 2020 01:48:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jWsiaE+j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726019AbgJ3IoB (ORCPT + 99 others); Fri, 30 Oct 2020 04:44:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:51580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgJ3IoB (ORCPT ); Fri, 30 Oct 2020 04:44:01 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88CB02075E; Fri, 30 Oct 2020 08:43:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604047440; bh=BADdsaGSmKEWz7XlhZAacYvZU3dbPRUVwNoUa9EQ9fY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jWsiaE+jA/WD/bs1UBm0uEdmn22Y4A1qlUCKFpn9Niob/NbNcIjYmoTLUaF9bFI+c +XhL6Nz1FUX2R/Kw033G8Mt4ZY7DWfOyUVejoQJJM4z+bJFglLaN9WyPisL8y90Q9G TTSSMYIXmv5A6Y+FIb4hYD/Q7aLgwt8hdWd3daLA= Date: Fri, 30 Oct 2020 09:44:48 +0100 From: Greg KH To: Luo Jiaxing Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org, martin.petersen@oracle.com, john.garry@huawei.com, himanshu.madhani@cavium.com, felipe.balbi@linux.intel.com, uma.shankar@intel.com, anshuman.gupta@intel.com, animesh.manna@intel.com, linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Message-ID: <20201030084448.GA1625087@kroah.com> References: <1604046722-15531-1-git-send-email-luojiaxing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1604046722-15531-1-git-send-email-luojiaxing@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 04:31:57PM +0800, Luo Jiaxing wrote: > We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute > for read-only file, but we found many of drivers also want a helper marco for > read-write file too. > > So we try to add this macro to help decrease code duplication. > > Luo Jiaxing (5): > seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro > scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs > scsi: qla2xxx: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs > usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE > drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs What changed from v1? thanks, greg k-h