Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To:     Leo Li <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Varun Sethi <V.Sethi@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: RE: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for
 lx2162aqds board
Thread-Topic: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for
 lx2162aqds board
Thread-Index: AQHWlkeuodA6cP2CUE+mv343XFniRamev/QwgArj8QCAAHohgIAF5pBw
Date:   Fri, 30 Oct 2020 08:59:10 +0000
Message-ID: <AM7PR04MB6885349E64FD6DF77C1A8F938E150@AM7PR04MB6885.eurprd04.prod.outlook.com>
References: <1599059610-7570-2-git-send-email-meenakshi.aggarwal@nxp.com>
 <1601373718-13218-1-git-send-email-meenakshi.aggarwal@nxp.com>
 <1601373718-13218-3-git-send-email-meenakshi.aggarwal@nxp.com>
 <AM7PR04MB6885980FC5B035B955D009BA8E1E0@AM7PR04MB6885.eurprd04.prod.outlook.com>
 <20201026071839.GE9880@dragon>
 <VE1PR04MB66876F05E9988139C03294498F190@VE1PR04MB6687.eurprd04.prod.outlook.com>
In-Reply-To: <VE1PR04MB66876F05E9988139C03294498F190@VE1PR04MB6687.eurprd04.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 01ff6662-a4d7-4c0c-6abb-08d87cb21102
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 08:59:10.3303
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t6KVBaAhcmB1EgKVHOzwHyuaYAbOGSr1XfFG6tPrJhX00/hKOIePwewdmWpbLiZafANU4EwOK2T8g8uj5uyDXINw/OcCTh6dThhEs6x8Tyk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7606
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shawn,

I will document "nxp,lx2162a-qds".
For ethernet string, documentation seems correct.

Thanks,
Meenakshi
> -----Original Message-----
> From: Leo Li <leoyang.li@nxp.com>
> Sent: Monday, October 26, 2020 8:06 PM
> To: Shawn Guo <shawnguo@kernel.org>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>
> Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; linux-arm-
> kernel@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Ioana Ciornei <ioana.ciornei@nxp.com>; Kuldeep Si=
ngh
> <kuldeep.singh@nxp.com>
> Subject: RE: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for lx21=
62aqds
> board
>=20
>=20
>=20
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: Monday, October 26, 2020 2:19 AM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li
> > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana
> > Ciornei <ioana.ciornei@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com>
> > Subject: Re: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for
> > lx2162aqds board
> >
> > On Mon, Oct 19, 2020 at 09:00:33AM +0000, Meenakshi Aggarwal wrote:
> > > Hi,
> > >
> > > Any further comments?
> >
> > Please address the following checkpatch warnings.
> >
> > WARNING: DT compatible string "nxp,lx2162a-qds" appears un-documented
> > -- check ./Documentation/devicetree/bindings/
> > #49: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:13:
> > +	compatible =3D "nxp,lx2162a-qds", "fsl,lx2160a";
> >
> > WARNING: DT compatible string "ethernet-phy-id001c.c916" appears un-
> > documented -- check ./Documentation/devicetree/bindings/
> > #80: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:44:
> > +				compatible =3D "ethernet-phy-id001c.c916";
>=20
> Interesting that it doesn't match the following in
> Documentation/devicetree/bindings/net/ethernet-phy.yaml
>=20
>       - pattern: "^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$"
>         description:
>           If the PHY reports an incorrect ID (or none at all) then the
>           compatible list may contain an entry with the correct PHY ID
>           in the above form.
>           The first group of digits is the 16 bit Phy Identifier 1
>           register, this is the chip vendor OUI bits 3:18. The
>           second group of digits is the Phy Identifier 2 register,
>           this is the chip vendor OUI bits 19:24, followed by 10
>           bits of a vendor specific ID.
>=20
> >
> > WARNING: DT compatible string "ethernet-phy-id001c.c916" appears un-
> > documented -- check ./Documentation/devicetree/bindings/
> > #92: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:56:
> > +				compatible =3D "ethernet-phy-id001c.c916";
> >
> >
> > Shawn