Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340
 PHYs
Thread-Topic: [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340
 PHYs
Thread-Index: AQHWkz9KW9hXanXbvUq7vxANMoo+Vqmve7IAgACfMoA=
Date:   Fri, 30 Oct 2020 09:40:27 +0000
Message-ID: <20201030094025.cudb2ezjaqxledt4@skbuf>
References: <20200925132503.30206-1-ioana.ciornei@nxp.com>
 <20200925132503.30206-6-ioana.ciornei@nxp.com>
 <20201030001038.GU28755@dragon>
In-Reply-To: <20201030001038.GU28755@dragon>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16C171C018D98D489F3EED2EF96AB6DA@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c76ebc1e-c9d4-4696-1fb2-08d87cb7d5a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 09:40:27.7522
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IDrqfqLsIn240fM84eMtPBjMrwNLth4GKygWO8DXuf/5ht+O7iI2Ml7madbnuJF3YjRrZEWNuYzNmcloVJdLEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5565
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 30, 2020 at 08:10:38AM +0800, Shawn Guo wrote:
> On Fri, Sep 25, 2020 at 04:24:59PM +0300, Ioana Ciornei wrote:
> > Annotate the EMDIO1 node and describe the 4 10GBASER PHYs found on the
> > LS2088ARDB board. Also, add phy-handles for DPMACs 1-4 to their
> > associated PHY.
> >=20
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > ---
> >  .../boot/dts/freescale/fsl-ls2088a-rdb.dts    | 41 +++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >=20
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts b/arch/a=
rm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> > index f6b4d75a258b..0d1935fcd201 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> > @@ -22,3 +22,44 @@ chosen {
> >  		stdout-path =3D "serial1:115200n8";
> >  	};
> >  };
> > +
> > +&dpmac1 {
> > +	phy-handle =3D <&mdio1_phy1>;
> > +};
> > +
> > +&dpmac2 {
> > +	phy-handle =3D <&mdio1_phy2>;
> > +};
> > +
> > +&dpmac3 {
> > +	phy-handle =3D <&mdio1_phy3>;
> > +};
> > +
> > +&dpmac4 {
> > +	phy-handle =3D <&mdio1_phy4>;
> > +};
> > +
> > +&emdio1 {
> > +	status =3D "okay";
> > +
> > +	mdio1_phy1: emdio1_phy@1 {
> > +		compatible =3D "ethernet-phy-id13e5.1002";
> > +		reg =3D <0x10>;
> > +		phy-connection-type =3D "10gbase-r";
> > +	};
>=20
> Please have a newline between nodes.
>=20

Sure.=