Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1140825pxx; Fri, 30 Oct 2020 03:11:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZ7c4gS3NCeWDwkEu62rY2FvzLlGiPsQ6s52jdnp15NtaJ1tS2aQzWQ0P7wLYCFDLtxKtv X-Received: by 2002:a05:6402:1586:: with SMTP id c6mr1474222edv.84.1604052665023; Fri, 30 Oct 2020 03:11:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604052665; cv=none; d=google.com; s=arc-20160816; b=p36ykLHBC5/Uvs/Hd8mOOIRuON7Upc8EtHNmreR1+PXQhKvM90TXw1SRxG/EwRdFpn f1/M7LTy1EPszg6fGCxaixrGFC+JnxaVaZDti4w9FAQrRNKpXav9R3Bw88FQj0gyXG/E 5IyU6PI58ntE/Pb8WfTAYMbCeqlEQRiUrWLRpBitisBH4hti5rmTn6Q1WU2wPQFX9Mxm QNUiKOJtBSIB1yUSfQj8t7LWSIajv5f+HbJSw0cp2merX+MU1kDtbqr7JLTdOGNpqknb rSJwZMwsLEms8dkPNUm3E3cxJ8mSEzsIYn32Z42RJ3AwJYb2EmWQkfS1neAXL/j5rC3V TKXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:reply-to:ironport-sdr:ironport-sdr; bh=hS6dxruBhETqThK9/OWurG21H7HZRGa0RxJhobeWk6Y=; b=avTTYWNANCA2UQd6LIVVHRUn1vKq9xX2gV0QAboKr7geBDrtHag59xm1SB5DULQbQJ j9an94SaduoYOny1jwyCIGgpOXmFfftwnV+5DlQroC+QxBbXzAFz08PRyMeorbWlYJ/2 +beAPAPzQEd+6u3hWv+wSOlRAC2Q4Xmr0G5tAXGQtGpE95YlItMkKMIJ4JmIFuHkvFpP PiqGR5u00Vx4vPabicZQm81sHg8Vjoz/8gNGqAaCAXryRuo3lXIE9JRGrPKhteAXjFwe 6rljMbLmK2JtUNCh/UMucT49VZ69/2z+PECykSSr5cbYthqq2QCORIW1+cznD32FC1pM bOxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si3824444edr.541.2020.10.30.03.10.42; Fri, 30 Oct 2020 03:11:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726529AbgJ3KJE (ORCPT + 99 others); Fri, 30 Oct 2020 06:09:04 -0400 Received: from mga04.intel.com ([192.55.52.120]:18571 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgJ3KJA (ORCPT ); Fri, 30 Oct 2020 06:09:00 -0400 IronPort-SDR: pOqnZk97Qp2Cfq5nAvaj6YundiAF5BvX9sQu2QzCcqJmP3wwg0/yvDOTCBJZAHEhFOmgK+y/Fm CjV3fscx24KQ== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="166000819" X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="166000819" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 03:09:00 -0700 IronPort-SDR: mFvDCriwTsMm57moiZ5dHGjEUb97JPysXglsWYC7Z6KfmLA+w07/xGl9mpfV4Hf9+u/kqIdyHq WWzYj5zMardg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="356553438" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 30 Oct 2020 03:08:59 -0700 Received: from [10.255.142.248] (vramuthx-MOBL1.gar.corp.intel.com [10.255.142.248]) by linux.intel.com (Postfix) with ESMTP id 86BAD5808A3; Fri, 30 Oct 2020 03:08:49 -0700 (PDT) Reply-To: vadivel.muruganx.ramuthevar@linux.intel.com Subject: Re: [RESENDPATCH v15 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC To: Miquel Raynal Cc: vigneshr@ti.com, tudor.ambarus@microchip.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, robh+dt@kernel.org, boris.brezillon@collabora.com, devicetree@vger.kernel.org, simon.k.r.goldschmidt@gmail.com, dinguyen@kernel.org, richard@nod.at, cheol.yong.kim@intel.com, qi-ming.wu@intel.com References: <20201026073021.33327-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20201026073021.33327-3-vadivel.muruganx.ramuthevar@linux.intel.com> <20201028112037.326c06e2@xps13> <20201030092329.280466d9@xps13> From: "Ramuthevar, Vadivel MuruganX" Message-ID: <3ac47b27-5399-e0e7-43f3-d4394c26f800@linux.intel.com> Date: Fri, 30 Oct 2020 18:08:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201030092329.280466d9@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, Thank you for the review comments... On 30/10/2020 4:23 pm, Miquel Raynal wrote: >>>> + >>>> +static const struct of_device_id ebu_nand_match[] = { >>>> + { .compatible = "intel,nand-controller", }, >>> No version or soc in the compatible? (not mandatory). >> Yes, you're right, it should be "intel,lgm-ebunand", but this same driver supports 2 dfferent SOC's , that's the reason kept as generic >> "intel,nand-controller" > In this case I guess declaring two compatibles is the way to go. Ok, Noted. Best Regards Vadivel