Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1156906pxx; Fri, 30 Oct 2020 03:39:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyih2KzJr/3LOTRKgBPDY66DSYp43h5gkp03TdJlvt4uII90e9tIu3egyiHch8VgFarmTc1 X-Received: by 2002:a17:906:a090:: with SMTP id q16mr1722415ejy.220.1604054376143; Fri, 30 Oct 2020 03:39:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604054376; cv=none; d=google.com; s=arc-20160816; b=TLYonbHotP4QC5MihWh0dtc9jI/fBQATXUOtK7kxjvrsiNCV6MpbceWfZzWuK6peMb AewxWgc2A0IIgRg03hKSGkhApFFUMvxklMYiWPkY4ay7P9gGeB0Zj1nk9tUPzwcErxxh eXMNa9hy9CSVv9krX2799FIy8nxfCB30hS/VTwMSilJqsQ7ApMJv/5Ly1zY1G/BnzVyt JLd7z5adOuXqMKane/zhmQENuEWXxtn9sEquozXEQDcaYDB9qdHWKt7PALDEUueQkWBz RTXP4NygP51NtyhDilCFH14ZovwS1n65zIpM0Wc9l52AhPLvrFo7EltvPoxZfUm6f/8C T7tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=v5X4DABLZygEHF6g8MNyK/mLSnF7d/XtqPovUL2Ojbs=; b=Td5POJ/NjLQTv1eSSn7540hrfIyvw2XltOsA0FcAo4jxuME+a9MIcUCEHI6MSh3hvw BusGhtmU899+J7F4N5nlVoCzHYOLeuKPlqMxyxvcuf2KZcrq8ruNPsXh5vr9o2ZlNMzR ZhVzY0p12HN1wr82OGCUrjQHtUDTNXh5OQieNHoN7VoNHjnoce4LIjQu7ZmyrPSgTHd9 lGKCDApxZ6Gw9LcnU1jZGyeBmxTppP8ENpDM+H5PrnAq2P7xVdRrQAFeLRpBwyVDR4ij XrQB1feX8GgodaKXbGPDlaxAG57PAwxDRhQx1TR4w4wdTQCgRLmcyCePTmNft7HEebVg C3/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2FxmcBZe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g9si4021670edr.404.2020.10.30.03.39.13; Fri, 30 Oct 2020 03:39:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2FxmcBZe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgJ3Ke6 (ORCPT + 99 others); Fri, 30 Oct 2020 06:34:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:60752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725790AbgJ3Ke6 (ORCPT ); Fri, 30 Oct 2020 06:34:58 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E554C20704; Fri, 30 Oct 2020 10:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604054097; bh=dH/Euy84o8UAK6ZWf2evrfdJN2070vU7e+DONC1HjU0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2FxmcBZeAumkCwIR+WD1V3Ity4QOnJ+X8IY0pyUPDJGqIa9e5VMRud/7w2mS5F4br puB16ElAhqhzV24NCk32SoQshv/jPGqdpIe+pUVhLnHTNYh2Bgv0Xfie/RNRjGbD4r Z+ymhqPKKslf/J8O5ratBR+SHombmiqmWQzNNN5w= Date: Fri, 30 Oct 2020 18:34:49 +0800 From: Shawn Guo To: Anson Huang Cc: robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, krzk@kernel.org, aford173@gmail.com, daniel.baluta@nxp.com, shengjiu.wang@nxp.com, peter.chen@nxp.com, alifer.wsdm@gmail.com, abel.vesa@nxp.com, yibin.gong@nxp.com, jun.li@nxp.com, l.stach@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration Message-ID: <20201030103449.GR28755@dragon> References: <1602506642-5262-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1602506642-5262-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 08:44:00PM +0800, Anson Huang wrote: > Different revision of i.MX8MM EVK boards may have different external > pull up registor design, some are enabled while some are NOT, to make > sure the WDOG_B pin works properly, better to enable internal pull up > resistor. Since enabling internal pull up resistor is NOT harmful and > having benefit of flexibility on different board design, just enable > it for all i.MX8MM boards; And schmitt input is NOT necessary for this > WDOG_B output pin, so remove it; Open drain outputs provide more > flexibility to a designer as they can be pulled-up to any voltage found > in the system, so enable it as well. > > Signed-off-by: Anson Huang Applied all, thanks.