Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: HSpWwG8ejSARafSDwCtr9AQP+Bghg+5FEGYndrQAlzlkTfbnw4MLZQY+gtO9QwXXsZXAmRXdlF
 LBr0rhmrwoYg==
IronPort-SDR: rL+b36wdeO4Dyvcky/eu86oR89lNAHQ9SZWlYgIKzLNjNwq8EDlVylgO92Q5L8N7pxE7NPDR4F
 /dGSJuOMiX2g==
Date:   Fri, 30 Oct 2020 12:58:34 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH] devres: zero the memory in devm_krealloc() if needed
Message-ID: <20201030105834.GL4077@smile.fi.intel.com>
References: <20201026122728.8522-1-brgl@bgdev.pl>
 <20201026131427.GF4077@smile.fi.intel.com>
 <CAMRc=MfuejMqpcfOedPMMTR3EY6s2K+4whoWyk7RmJYPaB176w@mail.gmail.com>
 <20201030105706.GK4077@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201030105706.GK4077@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Oct 30, 2020 at 12:57:06PM +0200, Andy Shevchenko wrote:
> On Fri, Oct 30, 2020 at 10:03:50AM +0100, Bartosz Golaszewski wrote:
> > On Thu, Oct 29, 2020 at 9:05 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > On Mon, Oct 26, 2020 at 01:27:28PM +0100, Bartosz Golaszewski wrote:
> > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > >
> > > > If we're returning the same pointer (when new size is smaller or equal
> > > > to the old size) we need to check if the user wants the memory zeroed
> > > > and memset() it manually if so.
> > >
> > > Any use case? Because to me it sounds contradictory to the whole idea of [k]realloc().
> > 
> > This is kind of a gray area in original krealloc() too and I want to
> > submit a patch for mm too. Right now krealloc ignores the __GFP_ZERO
> > flag if new_size <= old_size but zeroes the memory if new_size >
> > old_size.
> 
> > This should be consistent - either ignore __GFP_ZERO or
> > don't ignore it in both cases. I think that not ignoring it is better
> > - if user passes it then it's for a reason.
> 
> Sorry, but I consider in these two choices the best is the former one, i.e.
> ignoring, because non-ignoring for sizes less than current is counter the
> REalloc() by definition.
> 
> Reading realloc(3):
> 
> "If the new size is larger than the old size, the added memory will not be
> initialized."
> 
> So, supports my choice over yours.

Two notes:
 - perhaps kzrealloc() for what you want
 - there is a library call reallocarray() which supports your idea about
   krealloc_array() API in kernel.


-- 
With Best Regards,
Andy Shevchenko