Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1604026114-9038-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1604026114-9038-1-git-send-email-zou_wei@huawei.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 30 Oct 2020 13:15:05 +0200
Message-ID: <CAHp75Veq+j4zCH-CktYU3Qua6ZKHpqzpzm_yWZuzzvH3amoChg@mail.gmail.com>
Subject: Re: [PATCH -next v2] platform/x86/dell-wmi-sysman: Make some symbols static
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 30, 2020 at 4:38 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warnings:
>
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23: warning: symbol 'po_is_pass_set' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:70:23: warning: symbol 'po_current_password' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:99:23: warning: symbol 'po_new_password' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:103:23: warning: symbol 'po_min_pass_length' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:107:23: warning: symbol 'po_max_pass_length' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:116:23: warning: symbol 'po_mechanism' was not declared. Should it be static?
> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:129:23: warning: symbol 'po_role' was not declared. Should it be static?

Above can be shrinked by removing the path.

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> v2:
> - put all of them in a way that each occupies only a single line

I meant the code, like

> -struct kobj_attribute po_is_pass_set =
> +static struct kobj_attribute po_is_pass_set =
>                 __ATTR_RO(is_enabled);

==>

static struct kobj_attribute po_is_pass_set = __ATTR_RO(is_enabled);

-- 
With Best Regards,
Andy Shevchenko