Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1604050097-91302-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1604050097-91302-1-git-send-email-zou_wei@huawei.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 30 Oct 2020 13:18:33 +0200
Message-ID: <CAHp75Vd46nO9nXAZZ5-XKZR3_wq-o37MdmLNm_KUTSvhsq+whQ@mail.gmail.com>
Subject: Re: [PATCH -next] usb: Make sync_all_pins static
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Al Cooper <alcooperx@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        USB <linux-usb@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 30, 2020 at 11:18 AM Zou Wei <zou_wei@huawei.com> wrote:

The title can be more precise.

> Fix the following sparse warning:
>
> drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?

Do we really need to know the path?

> The sync_all_pins has only call site within brcmstb-usb-pinmap.c

sync_all_pins()

> It should be static

Missed period.

-- 
With Best Regards,
Andy Shevchenko