Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1185375pxx; Fri, 30 Oct 2020 04:23:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx9GDRLcQ7NUADVAvhGO0zVAV23OtVDOv3dGnYHEVxDpPkSLOkEiomvM048AlRP7lSYiXt X-Received: by 2002:a05:6402:2076:: with SMTP id bd22mr1813704edb.197.1604057023128; Fri, 30 Oct 2020 04:23:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604057023; cv=none; d=google.com; s=arc-20160816; b=jsGpIiDM7yJbo8AtgyKZb+rgixUfs2IdGnUfywUoifaAK+1F1M4CbgLZTfFhEGu5PB vkSrBv42nBdcRABZLWEVPghZkAHo0/U1a1Q37RAxs43UzL73KiqoiQoCuabm81jkmDwT Ze24iPe7tvyexK0NEDw0yi826NO8V9sT78mizDglUpYxaVnJifnJ/BV92+n+BkQ6rEdd NmaX5t7h7+BX2uLXpWxjR1/4rHI4SC6GA/Ei1uhTcd46RpGY9wWrgmlGC4BW48OCWY3n pcQHUPSZEdw4ZpQkLcCXR3On8Ih7A5vUITeM7JrMEh0dX4lXBjqLFBBzHAp+49EWrLc8 w0XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5RA/dTcPLcLSjFsM4pTf8628QTB+ljlVPvTwaOAvSI8=; b=LqOZ/nGxswIcshPiCCoax0zAeeq3Lzch2MAfLOR7TsnhkiMZPC6+LdITzE/oHm37th t5c9JqyXSIWv95YJhjbrR3CSLFlqPhKZxdluhkc+rSNhfB53J019gGH0oDosb1m5+M+s WmtNHFA7CUByKvobqGZLkfEoYqIOIJrI/S7+7jgzGwsKXJJstyIW1weP4z28/4oybwhL NRkXIxPxjFFtpbE9PwQ4xVZCE8zsMow+0ozEnWmIMLPY3vassOpNta/nzCGT4tzEDbMy 68CgN+qS/kvRBWxTKRt3Tsp7WkwQQVWtIBxqUr1uTGOObcNwAn9/Q5RcnLs2bKzqafNO NiRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=vPF6leW+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u17si3765125ejm.227.2020.10.30.04.23.20; Fri, 30 Oct 2020 04:23:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=vPF6leW+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbgJ3LTi (ORCPT + 99 others); Fri, 30 Oct 2020 07:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbgJ3LTh (ORCPT ); Fri, 30 Oct 2020 07:19:37 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63DBFC0613D5 for ; Fri, 30 Oct 2020 04:19:37 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id z5so7131645iob.1 for ; Fri, 30 Oct 2020 04:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5RA/dTcPLcLSjFsM4pTf8628QTB+ljlVPvTwaOAvSI8=; b=vPF6leW+6gfiBr1s7qfSqOlKqUhfUMZVxmg71BGMeoJBHzeltWCTbYEuXa0oT2dpud wFpsNu4u69HfrJAKI0EOaTm6zsS8jIGH3m+9HVCNWrLlCCPoSjJqD2wE8IxwVeOWCTT/ s9zIz/l9hy6s0sd/GXp4XfEvSvKGZqcAbjIb+9V91QPh/+m5tmqwRgj69T+okuTdts7j f8Rb2Xhxxuv3wU2FnzTR+xffJLffig2bPxtSDt6/d+Kun2cCrXvDLDclwQ1mGchUWUEe kh7V2O04DMTgLQ+QNYBQpIuNOLClV0FN3U+CjlNZaGC2yFYQ9Oo0c77oTqWY7rM+3aR7 b19w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5RA/dTcPLcLSjFsM4pTf8628QTB+ljlVPvTwaOAvSI8=; b=HmK8CMg2TzrZWbKn6nzR93wDDHBmDh7Jf5JILHAnVBIjyKTAwULcSq9Lfut1QhEhiu pel2iqa+GjRWDBLVhV5XeI58hAerJPUFTsiDQCrJJBqxJlTosuJCKt8MzVakD3uTdiY1 OT8bKFYqZkCF2xxQrJErL3pT4At9rBcD1SMCu3FH6Jl2mu46OxLFAAYDOOA8hEWqQ5dX +vDSBWmSxYeJOayEC9pUAO8njzIQKcVysIa7O6SjYbyFJJzwqKLeDYrGLIlx77ggNeCL boBthP3wsJWm/OEN5VAkIHhVULT3mizKbkTeT3z2i88cqFdGns0GeeVqmko1X6Ona87M 1oAA== X-Gm-Message-State: AOAM533FDTrIMG23TX0O+eaK+GibIqMzezJZdCTw4Aq4U7c8Fy3Uv4Zb IqMWhoL4QfuVlhJ3k4lnlfvowfciOUnJIgI794WX/KFbnh2Aep6q X-Received: by 2002:a5e:9244:: with SMTP id z4mr1374790iop.53.1604056776404; Fri, 30 Oct 2020 04:19:36 -0700 (PDT) MIME-Version: 1.0 References: <20201030075724.1616766-1-ajye_huang@compal.corp-partner.google.com> <20201030075724.1616766-3-ajye_huang@compal.corp-partner.google.com> In-Reply-To: From: Tzung-Bi Shih Date: Fri, 30 Oct 2020 19:19:25 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Modify machine driver for 2mic To: Ajye Huang Cc: Ajye Huang , Linux Kernel Mailing List , Mark Brown , Rohit kumar , Banajit Goswami , Patrick Lai , Srinivasa Rao Mandadapu , Srini Kandagatla , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Jaroslav Kysela , Cheng-Yi Chiang , Tzung-Bi Shih , Douglas Anderson , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 6:55 PM Ajye Huang wrote: > But dmic_get() will need dmic_switch, should i keep dmic_switch? I see. I overlooked it. You can keep the dmic_switch for this purpose or just call gpiod_get_value_cansleep().