Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: Re: (3) [PATCH v2] input: add 2 kind of switch
Reply-To: jryu.kim@samsung.com
Sender: Jungrae Kim <jryu.kim@samsung.com>
From:   Jungrae Kim <jryu.kim@samsung.com>
To:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        HyungJae Im <hj2.im@samsung.com>
CC:     "manivannan.sadhasivam@linaro.org" <manivannan.sadhasivam@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "rydberg@bitmath.org" <rydberg@bitmath.org>,
        Jungrae Kim <jryu.kim@samsung.com>
In-Reply-To: <20201030104628.GB2395528@kroah.com>
Message-ID: <20201030112812epcms1p7d031bb4949b319135e48dfac9409743b@epcms1p7>
Date:   Fri, 30 Oct 2020 20:28:12 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20201030104628.GB2395528@kroah.com>
        <20201029135715.GB3470996@kroah.com>
        <20201029132747epcms1p8fae559dff47bf0eebdcc9f94efd9a1bf@epcms1p8>
        <20201030043916epcms1p3b289ca5cd902883a97e7d13ceb5c1efb@epcms1p3>
        <CGME20201029132747epcms1p8fae559dff47bf0eebdcc9f94efd9a1bf@epcms1p7>
Precedence: bulk

> On Fri, Oct 30, 2020 at 01:39:16PM +0900, HyungJae Im wrote:
> > Hello, This is Hyungjae Im from Samsung Electronics.
> > Let me answer your questions inline.
> >=20
> > >On Thu, Oct 29, 2020 at 10:27:47PM +0900, HyungJae Im wrote:
> > >> From: =22hj2.im=22 <hj2.im=40samsung.com>
> > >> Date: Thu, 29 Oct 2020 22:11:24 +0900
> > >> Subject: =5BPATCH v2=5D input: add 2 kind of switch
> > >=20
> > >Why is this in the body of that patch?
> >=20
> > I read =22how to send your first kernel patch=22, but still making so m=
any mistakes.
> > I will be cautious with this.
> >=C2=A0=20=0D=0A>=20>=20>>=20=0D=0A>=20>=20>>=20We=20need=20support=20to=
=20various=20accessories=20on=20the=20device,=0D=0A>=20>=20>>=20some=20swit=
ch=20does=20not=20exist=20in=20switch=20list.=0D=0A>=20>=20>>=20So=20added=
=20switch=20for=20the=20following=20purpose.=0D=0A>=20>=20>>=20=0D=0A>=20>=
=20>>=20SW_COVER_ATTACHED=20is=20for=20the=20checking=20the=20cover=0D=0A>=
=20>=20>>=20attached=20or=20not=20on=20the=20device.=20SW_EXT_PEN_ATTACHED=
=20is=20for=20the=0D=0A>=20>=20>>=20checking=20the=20external=20pen=20attac=
hed=20or=20not=20on=20the=20device=0D=0A>=20>=20>=20=0D=0A>=20>=20>You=20di=
dn't=20answer=20the=20previous=20question=20as=20to=20why=20the=20existing=
=20values=20do=0D=0A>=20>=20>not=20work=20for=20you=20instead=20of=20having=
=20to=20create=20new=20ones?=0D=0A>=20>=20=0D=0A>=20>=C2=A0=20I=20think=20I=
=20should=20clarify=20this=20part=20the=20most=20for=20this=20review.=0D=0A=
>=20>=C2=A0=20As=20you=20know,=20new=20added=20events=20both=20has=20simila=
r=20existing=20events,=0D=0A>=20>=C2=A0=20but=20it=20has=20to=20operate=20s=
eparately.=0D=0A>=20>=20=0D=0A>=20>=C2=A0=20First,=20SW_COVER_ATTACHED=20is=
=20similar=20with=20SW_MACHINE_COVER.=0D=0A>=20>=C2=A0=20We=20need=20two=20=
events=20for=20our=20cover=20interaction.=0D=0A>=20>=C2=A0=20One=20is=20to=
=20detect=20if=20flip=20cover=20is=20open/closed(covers=20screen=20or=20not=
),=0D=0A>=20>=C2=A0=20and=20one=20is=20for=20detecting=20if=20cover=20is=20=
attached(detect=20if=20device=20is=20put=20into=20cover).=0D=0A>=20>=C2=A0=
=20With=20the=20second=20event,=20we=20send=20event=20for=20attachment=20an=
d=20start=20authentication=0D=0A>=20>=C2=A0=20distinguishing=20if=20it=20wa=
s=20Samsung=20made=20cover.=0D=0A>=20>=20=0D=0A>=20>=C2=A0=20Second,=20SW_E=
XT_PEN_ATTACHED=20detects=20if=20pen=20is=20attached=20externally=20on=20ta=
blet=20models.=0D=0A>=20>=C2=A0=20It=20is=20different=20with=20SW_PEN_INSER=
TED=20since=20this=20is=20detecting=20pens=20like=20our=20NOTE=20series.=0D=
=0A>=20>=C2=A0=20SW_EXT_PEN_ATTACHED=20has=20an=20unique=20role=20to=20set=
=20wacom=20tuning=20table=20differently=0D=0A>=20>=C2=A0=20while=20pen=20is=
=20attached/detached.=0D=0A>=C2=A0=20=0D=0A>=20All=20of=20that=20needs=20to=
=20go=20in=20the=20changelog=20text=20for=20the=20individual=20patches=0D=
=0A>=20when=20you=20submit=20them.=0D=0A>=C2=A0=20=0D=0A>=20But=20as=20Dmit=
ry=20pointed=20out,=20it=20doesn't=20look=20like=20either=20of=20these=20dr=
ivers=0D=0A>=20are=20needed=20at=20all,=20just=20use=20the=20gpio-keys=20dr=
iver=20instead.=0D=0A>=C2=A0=20=0D=0A>=20thanks,=0D=0A>=C2=A0=20=0D=0A>=20g=
reg=20k-h=0D=0A=C2=A0=0D=0ACan=20you=20accept=20V1=20patch?=20or=20need=20t=
o=20add=20a=20change=20of=20device=20tree?=0D=0APlease=20let=20me=20know=20=
what=20do=20I=20do=20now.=C2=A0