Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] vhost/vsock: add IOTLB API support
To:     Stefano Garzarella <sgarzare@redhat.com>
Cc:     mst@redhat.com, netdev@vger.kernel.org,
        Stefan Hajnoczi <stefanha@redhat.com>, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20201029174351.134173-1-sgarzare@redhat.com>
 <751cc074-ae68-72c8-71de-a42458058761@redhat.com>
 <20201030105422.ju2aj2bmwsckdufh@steredhat>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <278f4732-e561-2b4f-03ee-b26455760b01@redhat.com>
Date:   Fri, 30 Oct 2020 19:44:43 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201030105422.ju2aj2bmwsckdufh@steredhat>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2020/10/30 下午6:54, Stefano Garzarella wrote:
> On Fri, Oct 30, 2020 at 06:02:18PM +0800, Jason Wang wrote:
>>
>> On 2020/10/30 上午1:43, Stefano Garzarella wrote:
>>> This patch enables the IOTLB API support for vhost-vsock devices,
>>> allowing the userspace to emulate an IOMMU for the guest.
>>>
>>> These changes were made following vhost-net, in details this patch:
>>> - exposes VIRTIO_F_ACCESS_PLATFORM feature and inits the iotlb
>>>   device if the feature is acked
>>> - implements VHOST_GET_BACKEND_FEATURES and
>>>   VHOST_SET_BACKEND_FEATURES ioctls
>>> - calls vq_meta_prefetch() before vq processing to prefetch vq
>>>   metadata address in IOTLB
>>> - provides .read_iter, .write_iter, and .poll callbacks for the
>>>   chardev; they are used by the userspace to exchange IOTLB messages
>>>
>>> This patch was tested with QEMU and a patch applied [1] to fix a
>>> simple issue:
>>>     $ qemu -M q35,accel=kvm,kernel-irqchip=split \
>>>            -drive file=fedora.qcow2,format=qcow2,if=virtio \
>>>            -device intel-iommu,intremap=on \
>>>            -device vhost-vsock-pci,guest-cid=3,iommu_platform=on
>>
>>
>> Patch looks good, but a question:
>>
>> It looks to me you don't enable ATS which means vhost won't get any 
>> invalidation request or did I miss anything?
>>
>
> You're right, I didn't see invalidation requests, only miss and updates.
> Now I have tried to enable 'ats' and 'device-iotlb' but I still don't 
> see any invalidation.
>
> How can I test it? (Sorry but I don't have much experience yet with 
> vIOMMU)


I guess it's because the batched unmap. Maybe you can try to use 
"intel_iommu=strict" in guest kernel command line to see if it works.

Btw, make sure the qemu contains the patch [1]. Otherwise ATS won't be 
enabled for recent Linux Kernel in the guest.

Thanks

[1] https://patchew.org/QEMU/20200909081731.24688-1-jasowang@redhat.com/

>
> Thanks,
> Stefano
>