Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1213200pxx; Fri, 30 Oct 2020 05:05:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsQijCWYGQbxZ9dxJnvjxrbXDmUcOvG5qaOKzXdVw0Zvf1CZS/vlfHrYT3mEOcrM8h/wOU X-Received: by 2002:a17:906:3641:: with SMTP id r1mr2178822ejb.391.1604059523263; Fri, 30 Oct 2020 05:05:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604059523; cv=none; d=google.com; s=arc-20160816; b=VevK3+Lo00Z8gx2po6+UgPuxxANBc54HCFdnKa3Arb85NvMrZc8cQtkTrqw3uh+vDk zzFoAnOmr5xFzqngARc57Bat5hpy7G2juDHb5x0Z6yX/sgEyAnBxe/4mumGSIaGsEGQs 69yW2DLdX+sNNhm+LYwDQ2zuZUAlaF5iXjf0C0AU4qEyD49HNs1YMiuMBxrNVBv8Btvx h1FiF/slo/DfjduCDrB9VY6yVW0hP+HERL99eX66Nhy+32C3hGX/hPpckhWN05DxLQbV 2NxjCSgkz5iNv2LpUonKeJZ6FnqfEBJFDYJPx1coYfbi+ak8fYSCjOMZtEqKXIZmIpOf l0Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=rNq2Zfxvzm57VdYBL3I2bff9Y+07X81lkXYsCB6Of6k=; b=x9zlhacub1cj74W8uI+1vGD+MdPNN6Mdzhb/mHDqj6p0abLoihlPKCLxv41eQpc9D3 52lCxZ0u3PtwNI4Dsnz3rTq0/WNRGFypjC2+UBh3gWcFU1TqyFiY3ZZzRtxSWnaCtQ+4 oyJTTQfc5jm842kky9n3XrptC8Duaibd7uzkscjNYlIaDDwSf3u4VvX6Uii78RsYLJDV Rm2K8nbaEE/pQGKnzKRDGJj4Xff79jYv0Qr3yYh3iyQUqDcMaxmQd3qKXZHEVoOsIrOw s0nNct0rV8lHLS5FwhK2os/9IKE6hClRrY9hvhdMReMUwCayCvOl9FxnVkD1QVEV9bnL SBJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="h/93EuGC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si4028751ejf.66.2020.10.30.05.04.54; Fri, 30 Oct 2020 05:05:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="h/93EuGC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726055AbgJ3MAp (ORCPT + 99 others); Fri, 30 Oct 2020 08:00:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45257 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbgJ3MAp (ORCPT ); Fri, 30 Oct 2020 08:00:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604059243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rNq2Zfxvzm57VdYBL3I2bff9Y+07X81lkXYsCB6Of6k=; b=h/93EuGCdaLpfNGLwyaEbBDU2u0niZMXwv92xf++X3BNpxGp6Gz/x+XrZnkxMbIj9mjtFu hPsnoN1pNcpQXWyAyCU1hJf7RbVWVSYNUZ8EzpdyuBFa9WPAFRJTOBpwxq8AM/x9CLhDpX 7lGNqqJIBRmvqDzyqKHI/CRqOxF4IEU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-T42lQ-NzP2iqpOaPm4nVfw-1; Fri, 30 Oct 2020 08:00:41 -0400 X-MC-Unique: T42lQ-NzP2iqpOaPm4nVfw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB51110866C3; Fri, 30 Oct 2020 12:00:40 +0000 (UTC) Received: from ovpn-66-212.rdu2.redhat.com (ovpn-66-212.rdu2.redhat.com [10.10.66.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id E279B1001281; Fri, 30 Oct 2020 12:00:04 +0000 (UTC) Message-ID: <8b57dd7972f54fcf271a5790696cbd6c950269ff.camel@redhat.com> Subject: Re: WARN_ON(fuse_insert_writeback(root, wpa)) in tree_insert() From: Qian Cai To: Miklos Szeredi Cc: Vivek Goyal , Stefan Hajnoczi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, virtio-fs-list Date: Fri, 30 Oct 2020 08:00:03 -0400 In-Reply-To: References: <89f0dbf6713ebd44ec519425e3a947e71f7aed55.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-10-29 at 16:20 +0100, Miklos Szeredi wrote: > On Thu, Oct 29, 2020 at 4:02 PM Qian Cai wrote: > > On Wed, 2020-10-07 at 16:08 -0400, Qian Cai wrote: > > > Running some fuzzing by a unprivileged user on virtiofs could trigger the > > > warning below. The warning was introduced not long ago by the commit > > > c146024ec44c ("fuse: fix warning in tree_insert() and clean up writepage > > > insertion"). > > > > > > From the logs, the last piece of the fuzzing code is: > > > > > > fgetxattr(fd=426, name=0x7f39a69af000, value=0x7f39a8abf000, size=1) > > > > I can still reproduce it on today's linux-next. Any idea on how to debug it > > further? > > Can you please try the attached patch? So far so good. I'll keep running it over the weekend to be a little bit sure. It was taking a while to reproduce.