Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200927165947.7317-1-krzk@kernel.org> <20200927165947.7317-2-krzk@kernel.org>
 <CAHCN7xL2uda0OvkSvZ3tCBGT=WU9OxMqeXvmJaeBSpwb--4=zQ@mail.gmail.com>
In-Reply-To: <CAHCN7xL2uda0OvkSvZ3tCBGT=WU9OxMqeXvmJaeBSpwb--4=zQ@mail.gmail.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Fri, 30 Oct 2020 07:25:52 -0500
Message-ID: <CAHCN7xKd=ba9j2D-VSkQf=2YNEm0LR1C+nk8n4C-kCJ3e0NV4g@mail.gmail.com>
Subject: Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's
 interrupt line pull-up
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Anson Huang <Anson.Huang@nxp.com>,
        Peter Chen <peter.chen@nxp.com>,
        devicetree <devicetree@vger.kernel.org>,
        arm-soc <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Oct 7, 2020 at 7:51 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Sun, Sep 27, 2020 at 12:00 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > The PMIC's interrupt is level low and should be pulled up.  The PMIC's
> > device node had pinctrl-0 property but it lacked pinctrl-names which
> > is required to apply the pin configuration.
> >
>
> Thanks for the fixes!
>
> > Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Tested-by: Adam Ford <aford173@gmail.com>
>

Shawn,

Any chance you can apply this series?  Without this patch, the pmic
driver throws some splat due to a previous fix.

thanks

adam
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > index 6de86a4f0ec4..55b36bddd513 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > @@ -72,6 +72,7 @@
> >         pmic@4b {
> >                 compatible = "rohm,bd71847";
> >                 reg = <0x4b>;
> > +               pinctrl-names = "default";
> >                 pinctrl-0 = <&pinctrl_pmic>;
> >                 interrupt-parent = <&gpio1>;
> >                 interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > --
> > 2.17.1
> >