Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1287490pxx; Fri, 30 Oct 2020 06:45:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxwRDTypR1A90lvAbaRU4pKD4dQexcXWoPlGtlxURK7fV2CWSyMH66zHlgp6JQ18hLpVvn X-Received: by 2002:a17:907:270f:: with SMTP id w15mr2437155ejk.505.1604065525335; Fri, 30 Oct 2020 06:45:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604065525; cv=none; d=google.com; s=arc-20160816; b=k1jD/l6EtINNHqdqG+yytwQMR+kdoLhhu5ypbgr/qb8m2hq5bnYemxPaz51EKSa3CC eI+LempEYoRPVksrKrzm4Nvo3fwGWrxiiRrS6Tqm7oyXDlCwdudbzqQ90geZjdsrTFbp C6qlhG/PndDuS6C1sOVUpg0mpPAAkP5lINnm1sHgAxTXLYNCluKytE308LIC3jAcwjEB RMsG5MVgoMITyW6sKR3wdobiMJ+4renhWeJ7rLErG62bT7eu7xOcdCvgOrThGLwHLS+z HnRIQHhjhe7HhXJy5BU4D/j83QObLwdooIhOmRaaslQcW0gfkk+2GESYVtIQraJjfqjH h3+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=pouhpxIOQlCIWh9w6FNAYEehMW+0/YgL8c4bikdqnTQ=; b=csxgBJRyiK9bTdaburaNqsrKRHTYAj1BErWdi3CHGupbplXQs11krseD8YwY6HRsrb t1AcwLcnjBOx7ijjZZMOw9rO83OuGR9lJ9w0G7aqjnrL2xJPiC0hWPLLoSGC7GtZdkkC LpDQei1gVj434zvHUcnNHvfF4KFhRGk0/VcaTdjIFgscgib0Q4ZqHe8fSfXdpZHERAhw 7gdADHmZRS8B1lHnjxOrimYRMMNh/wlYUCWF/g7eEr445A7fGdPzJCq+NyzeuWtf8Ccj QYjXf5cvF9XOle8Jkyrt+QY57ZBFuGA6xXySwcwCBomA08l+HYu6EMIfRcnaL7sq/SDc 3Tew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cn3si5532463edb.17.2020.10.30.06.45.03; Fri, 30 Oct 2020 06:45:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbgJ3NnW (ORCPT + 99 others); Fri, 30 Oct 2020 09:43:22 -0400 Received: from out28-77.mail.aliyun.com ([115.124.28.77]:37977 "EHLO out28-77.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726101AbgJ3NnW (ORCPT ); Fri, 30 Oct 2020 09:43:22 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1107079|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_alarm|0.0265387-0.00197939-0.971482;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047213;MF=liu.xiang@zlingsmart.com;NM=1;PH=DS;RN=5;RT=5;SR=0;TI=SMTPD_---.IqYD0cV_1604065398; Received: from localhost(mailfrom:liu.xiang@zlingsmart.com fp:SMTPD_---.IqYD0cV_1604065398) by smtp.aliyun-inc.com(10.194.99.38); Fri, 30 Oct 2020 21:43:18 +0800 From: Liu Xiang To: linux-serial@vger.kernel.org Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, Liu Xiang Subject: [PATCH] tty: serial: linflexuart: Remove unnecessary '|' operation and add error count Date: Fri, 30 Oct 2020 21:43:11 +0800 Message-Id: <1604065391-3790-1-git-send-email-liuxiang_1999@126.com> X-Mailer: git-send-email 1.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The '|' operation of status in linflex_rxint is unnecessary, so it can be removed. Signed-off-by: Liu Xiang --- drivers/tty/serial/fsl_linflexuart.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c index 3e28be4..d870480 100644 --- a/drivers/tty/serial/fsl_linflexuart.c +++ b/drivers/tty/serial/fsl_linflexuart.c @@ -252,23 +252,22 @@ static irqreturn_t linflex_rxint(int irq, void *dev_id) flg = TTY_NORMAL; sport->icount.rx++; - if (status & (LINFLEXD_UARTSR_BOF | LINFLEXD_UARTSR_SZF | - LINFLEXD_UARTSR_FEF | LINFLEXD_UARTSR_PE)) { - if (status & LINFLEXD_UARTSR_SZF) - status |= LINFLEXD_UARTSR_SZF; + if (status & (LINFLEXD_UARTSR_BOF | LINFLEXD_UARTSR_FEF | + LINFLEXD_UARTSR_PE)) { if (status & LINFLEXD_UARTSR_BOF) - status |= LINFLEXD_UARTSR_BOF; + sport->icount.overrun++; if (status & LINFLEXD_UARTSR_FEF) { - if (!rx) + if (!rx) { brk = true; - status |= LINFLEXD_UARTSR_FEF; + sport->icount.brk++; + } else + sport->icount.frame++; } if (status & LINFLEXD_UARTSR_PE) - status |= LINFLEXD_UARTSR_PE; + sport->icount.parity++; } - writel(status | LINFLEXD_UARTSR_RMB | LINFLEXD_UARTSR_DRFRFE, - sport->membase + UARTSR); + writel(status, sport->membase + UARTSR); status = readl(sport->membase + UARTSR); if (brk) { -- 1.9.1