Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1295044pxx; Fri, 30 Oct 2020 06:56:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlClfrCAI90ZIR2XCJMWN8iYBuXO3uNkDwn1wSw1wjOfSxdht3GpC2MzvkNxFNQ1YHxpAf X-Received: by 2002:a17:906:f11a:: with SMTP id gv26mr2698947ejb.376.1604066217625; Fri, 30 Oct 2020 06:56:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604066217; cv=none; d=google.com; s=arc-20160816; b=Wr5D1JJM1ZCi3161MgX/54UCXVv6wdVumAoEJ1QiPpnQR5bwPN00EH3D5Jy5tJvpO1 KgAUc3HcAquQ1yskQsPxhRKWZkIJWaaoQ5fH3VFzvl+1Twqjb1QLWkRbUTO197SwLVO2 B+5KE3IeQEP1pYEeJAxAolX7ChD0rirLg49XPtYG4snvWM4kLf2AMJ2iql5GuOXvOgk1 t4LY8PHn6lm+eLJCePRJySvPIJJ3sjLj+xI46+j0d+o+nh1n+GeGWn8FFA8cGWWTvlJi FLqQPhrHmYx2zfxl15uSKfzsPpYLTPF4jQRkiGpqKa5G1MORKOtrgqhvo88vaS1zDNNa X/wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=p1nkWHsTTJ1phk0MECInN7pnDwPUF1bojBnmQs9PZoM=; b=ycxKIiX18QVQ7TklmDmmmnuKVnqEGozyxQSWS7HJZvdpbBBWVUnsQ7iKVlYghAG4Ub rnBcJrohh+gCxN+Jtdgpg8Zc3l9kc3ACVFIkC16oonM6705PZln1591+h6WvaOYmlQiA FOchBTlkj6wySYql1nnNSvkKf8v6rTMJa0zqRP742X9mb/WQpJclEzANvBr4IAuGhbtN 3/NR5VrE+eU98WbA6DzVg7dZxtRDWpswPzHQORvfvQX1wSXvNUwQVMkA6CNNbiLUz8GG lDc6eGiyWOBFf4rIG5EbZrXQgIWIFUOzU9LuGho6KVVRMGp9763/QsjycbRefdkVqFhG Q0tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=JsNIng18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si4297829ejf.674.2020.10.30.06.56.33; Fri, 30 Oct 2020 06:56:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=JsNIng18; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbgJ3NyQ (ORCPT + 99 others); Fri, 30 Oct 2020 09:54:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726829AbgJ3NyE (ORCPT ); Fri, 30 Oct 2020 09:54:04 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E399CC0613D2 for ; Fri, 30 Oct 2020 06:54:03 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id r7so4865381qkf.3 for ; Fri, 30 Oct 2020 06:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=p1nkWHsTTJ1phk0MECInN7pnDwPUF1bojBnmQs9PZoM=; b=JsNIng18yHH5/LXDpPA+BwLTBHcs1T13ZwrR46DvSQd2iyr/I2H49p0AaTvTYPWxtu hRlzMwdMBF7gPpGJExMS3hcyvwcq2OLXMcHJRUYaIINATS2DLqUpB59uW/MCb8eG1cmy KIX7EF8KQzWW81n5ccWUkUQOY5wf00O99LDkOtjXk3o27fEMFo/HJDlPg7FqiHLAHTPP S8DBv/CExSuAh1XX/bl1C3LjbAgG1WJWjXBibLWMbrn+cWxhUD3vFLKq8SWWvl8XFGzZ 1q1WFkMcp6/IugaIHT2dqvt7HYV96HeBabnklmKeSNKFtYP/mXrizgDpZLO2t9x51Da1 lZsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=p1nkWHsTTJ1phk0MECInN7pnDwPUF1bojBnmQs9PZoM=; b=P7S/zJk/yQx0nli2p9733WAPicuO/NOyTbprC7dYHSqWlNPLz0Cg2fof4QA+TkzwKn mQAlSg4hcxK+tXrRMxNh0KOkdGMgm6vrBOg+A4twUZwOX3fYS28mv9fuOCvPljkbawmm 8ZSJoOTgCxiUVnwKBfc9pskPa38y/hDlOu467CIW5SFvCZ8cgsc+4xNABBlCwzQRIHSr dfjHsMOXRXSob3uKD6LQvsn++K8Eu5g7WwapSJ9z8zRo668hEzGLyeBCyaoSVQVhtn4u g98jnfukH37oP+mt3J71mpIpu182CpREKCYDzZZEt04H7c/MEMRB+KQ/M1vx/dXBJCaN B8WA== X-Gm-Message-State: AOAM532O1I43WKAlenX/v7vDAw5Pp4Nflhe8g+iUhCh1wVnqOXQQgaGK weIYOBPga+3Qsy7/THYS3BnOfQ== X-Received: by 2002:a05:620a:16dc:: with SMTP id a28mr2289149qkn.372.1604066043143; Fri, 30 Oct 2020 06:54:03 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:fb53]) by smtp.gmail.com with ESMTPSA id k4sm2577028qkj.46.2020.10.30.06.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 06:54:02 -0700 (PDT) Date: Fri, 30 Oct 2020 09:52:18 -0400 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Subject: Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail Message-ID: <20201030135218.GA666074@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-5-git-send-email-alex.shi@linux.alibaba.com> <20201029135047.GE599825@cmpxchg.org> <06a5b7d8-bbf2-51b7-1352-2b630186e15f@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <06a5b7d8-bbf2-51b7-1352-2b630186e15f@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 10:46:54AM +0800, Alex Shi wrote: > 在 2020/10/29 下午9:50, Johannes Weiner 写道: > > It may be better to pick either > > head and tail > > Hi Johannes, > > Thanks for comments! > > Right, Consider functions in this file are using head/tail more as parameters > I will change to use head/tail too. And then, the 04th, 05th, and 18th patch > will be changed accordingly. That's great, thank you! > From a9ee63a213f40eb4d5a69b52fbb348ff9cd7cf6c Mon Sep 17 00:00:00 2001 > From: Alex Shi > Date: Tue, 26 May 2020 16:49:22 +0800 > Subject: [PATCH v21 04/20] mm/thp: use head for head page in lru_add_page_tail > > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi > Reviewed-by: Kirill A. Shutemov > Acked-by: Hugh Dickins > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Acked-by: Johannes Weiner