Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        Yang Shi <shy828301@gmail.com>, Michal Hocko <mhocko@suse.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Rik van Riel <riel@surriel.com>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] mm/compaction: count pages and stop correctly
 during page isolation.
Date:   Fri, 30 Oct 2020 14:15:09 -0400
Message-ID: <DCB4BD99-5351-40AD-8F74-2BCCEAC496D1@nvidia.com>
In-Reply-To: <20201030181246.GM27442@casper.infradead.org>
References: <20201030155716.3614401-1-zi.yan@sent.com>
 <20201030181246.GM27442@casper.infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed;
        boundary="=_MailMate_573EF8E1-1214-4432-98D9-A4F76B6C57F8_=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk

--=_MailMate_573EF8E1-1214-4432-98D9-A4F76B6C57F8_=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 30 Oct 2020, at 14:12, Matthew Wilcox wrote:

> On Fri, Oct 30, 2020 at 11:57:15AM -0400, Zi Yan wrote:
>> In isolate_migratepages_block, when cc->alloc_contig is true, we are
>> able to isolate compound pages, nr_migratepages and nr_isolated did no=
t
>> count compound pages correctly, causing us to isolate more pages than =
we
>> thought. Use thp_nr_pages to count pages. Otherwise, we might be trapp=
ed
>                ^^^^^^^^^^^^
> Maybe replace that sentence with "Count compound pages as the number of=

> base pages they contain"?

Sure. And compound_nr is used instead of thp_nr_pages in fact.

OK. V3 is coming.

=E2=80=94
Best Regards,
Yan Zi

--=_MailMate_573EF8E1-1214-4432-98D9-A4F76B6C57F8_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl+cWC0PHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqK0+UP/A38KGcVHP+cTsJ91NYNXaCKVkiFmJwnt3l6
K4y+2ZfE2KtHh4uDZMex/WT20P9p6ktqHtYdG57Rdppi4bbMpUPQX6whffeHUdlq
d/EkPss31sAUl32VpC81HJeEjoCpDUCcUATCMs//0jl2zMHUzTegHzIZL4INmosy
b7tlN1APNY/xA9JIs/X1yITEp3aBjHnnG4nLKp6U2NdhDWo/AsQFiPppkBbL5fUI
1GgTb67HwKMZuYfja0/wrmhP7M2CxslcyimweojegjXGiL3lU9l91hSlH1l73PWc
ievwOYghyY+EV38zgTZu0JNdR+uYTLTWTn//uRAbXGzPzjEqMAWliqIVQ2aUF1Ht
KxtngTbB6ZQDdUpjNgE2Por8yoIYE7vL0Cw/sWpE410RuhBQ8QSQrrcK8KJLmI7y
hMcOAE0OjrN/FJRacXPO0a7MPTa0zdM7JcGUmKFylsW8Z3swQP6OXKU2iutrpH8h
CSnovLZxKfwINrepfbjYOVCknvDY5FLMQ/AHgqzxreYJVaZhgeqmzUC6a2AiOAuw
m9VmRxFuXGfa0qcHrCsr8+1wdNXtUux/TFeO7TLlkTOxECwSHqqcDLY1bPOaVyqm
ru++Z9qT4nni3ChedR8hsvdIxxHMriTaFC8XFWsFJXzfAfvCNyk8gBUuJbLKah3T
f9o5SAye
=DMW2
-----END PGP SIGNATURE-----

--=_MailMate_573EF8E1-1214-4432-98D9-A4F76B6C57F8_=--