Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1508235pxx; Fri, 30 Oct 2020 11:37:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmS/aySdjDPV4F8Ek8dWdRCNh7oyliFSuktQ+nNcJHmk4BQs0PSuLFz9g0U3/OTFSt7wk3 X-Received: by 2002:a17:906:6cb:: with SMTP id v11mr3974351ejb.31.1604083056332; Fri, 30 Oct 2020 11:37:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604083056; cv=none; d=google.com; s=arc-20160816; b=iw8faFKo+cIY2USg21yT3RkWbpvOnsbcLmoFqel6zWLU7OvKoFNJgwiMwDlZ9Q1ku0 Kiip36NLTVtFH+SZoNvyhBYnAu9OzAAZtyl4s7LOb2LKnZY51JroxI3hcn+pvWla6HWy N0Y5OUCWpz0zGV7Bn+wUu+ybo6Um0rT6Zcw5aARPAOf6X7oOpY1nDA26ClUKavKiZOIi hOW1Gpy0wTFesumaTGQD1iloRqwQoGrEmFm8kUKYRVc4qWzcVHD69QqXtt1PpExN7O2N iYQvcnYaTQcZ23f5rrJVoU3RmdvF+8oYycdkAghV8laNRXoZPk1OpWphEAMkHnu7H8YI 2b1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:content-disposition:mime-version :message-id:subject:to:from:date:dkim-signature; bh=arFiHimQtiFJb6n6XZtdH+1ty6P+gA0qV1YCQIOIjbk=; b=TzlM3e8r6lscgM1GQbHYGzESDpO0vGzl90fhR8X5SB0TjbD/B13jej3oZcWQvs9Rme XxKY/EcxAqCrGo3dnY0U8lqUAwxJ2T7eCeGvv9/U9jnRqBiX+da2IVmHfhVFiKsZbfai MTJN5Qksdwu/jCkURgsh73avvJKcLTuBPPzIrohFcr6/7+KIM0BJIxHNsqvDfXpGS4H/ 2hHqyMri5GR+39IKT7G68PJSAzQMMGuJO3eptZ2oDvN895L8YcTbX6xfO/UzaxP3HO8d ZZ/pSF3bOShw598RyDAt3Qgs9Q/DLq1lOCSiPTZtAU1fNUJJcQ9ctwfK2b0HkBptgS3l KrJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@earth.li header.s=the header.b=aJHkwdWk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o22si5032661ejj.86.2020.10.30.11.37.12; Fri, 30 Oct 2020 11:37:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@earth.li header.s=the header.b=aJHkwdWk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727258AbgJ3Sd2 (ORCPT + 99 others); Fri, 30 Oct 2020 14:33:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbgJ3Sd1 (ORCPT ); Fri, 30 Oct 2020 14:33:27 -0400 Received: from the.earth.li (the.earth.li [IPv6:2a00:1098:86:4d:c0ff:ee:15:900d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D96DC0613D2; Fri, 30 Oct 2020 11:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=arFiHimQtiFJb6n6XZtdH+1ty6P+gA0qV1YCQIOIjbk=; b=aJHkwdWk41/8ufHHLn2WXErvDb dSUEkmia/KuWPYiFNhG99EkAxwqDtmrRsVtEHBAsPL/Kof5rlu2W1676LwG/frn5/xY692AN+jiCi dCsEfi2RXzUzi+OTzezrj/v1XcjZAFtOfBaW/WcS6TwRem5OCX/4uctfIQysgAbh0SPHuub5SB3iO CsDE8JbSlwIymdTYGualZ2zoHw/i8qZwQyV346jMVe9jnuBfkodIkSjsa7/1N10/Gzkd8ydrmqstn 8bCyJzlVYMAkOoxkQ6gH30f25dFytHOMU8XnESJXrFWSi21vH9Dt05g/cVX7wb6dqU0tlN3wiZrD4 j2TNba8A==; Received: from noodles by the.earth.li with local (Exim 4.92) (envelope-from ) id 1kYZD9-0001uR-F7; Fri, 30 Oct 2020 18:33:15 +0000 Date: Fri, 30 Oct 2020 18:33:15 +0000 From: Jonathan McDowell To: DENG Qingfang , Vladimir Oltean , Andrew Lunn , Vivien Didelot , Florian Fainelli , David Miller , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net: dsa: qca8k: Fix port MTU setting Message-ID: <20201030183315.GA6736@earth.li> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The qca8k only supports a switch-wide MTU setting, and the code to take the max of all ports was only looking at the port currently being set. Fix to examine all ports. Reported-by: DENG Qingfang Fixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks") Cc: stable@vger.kernel.org Signed-off-by: Jonathan McDowell --- drivers/net/dsa/qca8k.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 53064e0e1618..5bdac669a339 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -1219,8 +1219,8 @@ qca8k_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu) priv->port_mtu[port] = new_mtu; for (i = 0; i < QCA8K_NUM_PORTS; i++) - if (priv->port_mtu[port] > mtu) - mtu = priv->port_mtu[port]; + if (priv->port_mtu[i] > mtu) + mtu = priv->port_mtu[i]; /* Include L2 header / FCS length */ qca8k_write(priv, QCA8K_MAX_FRAME_SIZE, mtu + ETH_HLEN + ETH_FCS_LEN); -- 2.20.1