Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1514462pxx; Fri, 30 Oct 2020 11:47:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU1eNoHrrbLNoGS3h3KrzLO9+wYHksK3r18+en0MrrnPqMNOxsJo/T0ayO6DmfYRXpD7Vz X-Received: by 2002:a50:e61a:: with SMTP id y26mr4038960edm.71.1604083621542; Fri, 30 Oct 2020 11:47:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604083621; cv=none; d=google.com; s=arc-20160816; b=ghD9//aLQOuRl+9yyuX4MeWZTAwLE18Hkxso89vRZfzrDMiN604q6Lsa3XdWcuG14T g2tirTEZJ+Oz4V+slwKefa/0VGg+8DVNhYypi5kY7iIoyQYima8pbdAvEO8z2Aa2yre0 HtVsJXUW+corcfQ9x3vUs1aegmKDNspd+N0DDgGf1aE1qO4grXYzzhG9TOn1LEPHidlj 1Q7+eIUWi+MCYJT6uw4P58v8w54cZ6j1HaSz9tklHGfXsnRk+450tku4og0p8G0uBoWd KytedEpni5N14VHbT4hdijyXK32yvO7WWz/nFHiMlJ+tEgw6FSpM/77zB84bES0h7+oI b5vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6pqKVGl72+yDQhAn6GGxKJCQjYcbcN3OUsLeJdjh2iM=; b=Z6pKGF/ThxzAonnlMUZctz/iew+8DxlTR5EGpiQXGUcVRhzoax1FpbXwnonrKLe0hK qkp7Olhb9TnWDe8cuSOiYYoA0ri+ey69q5KZ/2f5zkc04EY7lTIonAxvHnIbH7pirPcT 1zXvAfiLpd1GPTMx+w+Vpkm50k+f544yaB+uLz2kGbQn0KlpwDdiZfVmjp767XVsFVrG /nhkJvUuoRf3yDI9DRdkU0QSldNjO9rkaUsh1acn56qJeddri3ai+snAUla/LiwhoR5T D8n/ChD6dtsk/y6cnp973uz6v13YTTIJn0IrN/k63vpf7WmwS689fGy6XhBW+x78Gycm xpyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c9si5260727edn.152.2020.10.30.11.46.38; Fri, 30 Oct 2020 11:47:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727313AbgJ3SnC (ORCPT + 99 others); Fri, 30 Oct 2020 14:43:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbgJ3SnC (ORCPT ); Fri, 30 Oct 2020 14:43:02 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EB62C0613CF; Fri, 30 Oct 2020 11:43:02 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYZMV-00CDS5-Go; Fri, 30 Oct 2020 18:42:55 +0000 Date: Fri, 30 Oct 2020 18:42:55 +0000 From: Al Viro To: Qian Cai Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] fs: Fix memory leaks in do_renameat2() error paths Message-ID: <20201030184255.GP3576660@ZenIV.linux.org.uk> References: <20201030152407.43598-1-cai@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201030152407.43598-1-cai@redhat.com> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 11:24:07AM -0400, Qian Cai wrote: > We will need to call putname() before do_renameat2() returning -EINVAL > to avoid memory leaks. > > Fixes: 3c5499fa56f5 ("fs: make do_renameat2() take struct filename") > Signed-off-by: Qian Cai May I ask where has the original commit been posted for review? And why the bleeding hell does io_uring touch rename-related codepaths in the first place?