Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1516097pxx; Fri, 30 Oct 2020 11:49:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd6JLea1mad8x4yZ1YUqiEJ15de+lsgrkWSvuF7US1rX6qAc4UsFrKQ4fidQYf6oGFTkMO X-Received: by 2002:a50:da8d:: with SMTP id q13mr4081476edj.370.1604083778641; Fri, 30 Oct 2020 11:49:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604083778; cv=none; d=google.com; s=arc-20160816; b=o+OUVeu1m5gHyubykMMWUql6TkvT8iY4YGwk87xCxhEsW7zIFSay2+xeLj3Z/0U0t2 Vw6uFg4vzuvhiaMDHPQ/T9ucG7wqL5GRyOHRfiOCNU9H1t4ymUgUJLTpSfIjadjhshpd DEMtMgtYLBbQxiPbrOxSJJsQUgLbtBSHNc2VJ+JD7mh3il3FMDzExKhiKaH0R1aI7fbO Xd0KwxN1xvzstUYljISHIdrbz88PNWgde5khY5l8X9AHU6gKx7jUOafFen5gdKN4ybeL oStONvrSZjnvrS4GrpGehWzovGVTd/3AOf4HmkYrzviG4dcXAFg5+UrD9XaFq2gxLpsa hx2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=wU3MuYGIBzfmvEuvNCDmqckBinQlxglK+NR+sCZzkPU=; b=wIp5nVdI0/yO/gdzxEAsXVKgk754RfOZiKSeT0Pneny/wGrixX7C/ZAWOG86GfeXuo aFG1tizq40JY/10WIeV33TZzAMqdZhbAAsQjpIdAF9giQEjTlW9eywDaJr9jQFDXhhCA kK8zkKQ4nJ4jHlJqkAJvwzA9UfJrwFUebxEStz8dNjynGKZeJ7bDU6GNGVSM/cl7dPMD fbwfGf1qK39gQJuEonhh5y1csr4dE/SSjmwer7XbAXNu0JrPyodedmBUoK18H1F1ShoC Alpgl+FJW4F/o0oU4oKRUEFatR1IE3t4KipM8er8SburHjYN7NHbynWWJ1JlKWv5QsPA b5+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si5300377ejb.420.2020.10.30.11.49.16; Fri, 30 Oct 2020 11:49:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727313AbgJ3Srk (ORCPT + 99 others); Fri, 30 Oct 2020 14:47:40 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55262 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbgJ3Srj (ORCPT ); Fri, 30 Oct 2020 14:47:39 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kYZQz-004Orv-Cz; Fri, 30 Oct 2020 19:47:33 +0100 Date: Fri, 30 Oct 2020 19:47:33 +0100 From: Andrew Lunn To: Jonathan McDowell Cc: DENG Qingfang , Vladimir Oltean , Vivien Didelot , Florian Fainelli , David Miller , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: qca8k: Fix port MTU setting Message-ID: <20201030184733.GB1042051@lunn.ch> References: <20201030183315.GA6736@earth.li> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201030183315.GA6736@earth.li> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 30, 2020 at 06:33:15PM +0000, Jonathan McDowell wrote: > The qca8k only supports a switch-wide MTU setting, and the code to take > the max of all ports was only looking at the port currently being set. > Fix to examine all ports. > > Reported-by: DENG Qingfang > Fixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks") > Cc: stable@vger.kernel.org > Signed-off-by: Jonathan McDowell Reviewed-by: Andrew Lunn Andrew