Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1609812pxx; Fri, 30 Oct 2020 14:22:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3qmLTgFbSGQA1QTtq4B2gAXZNAZ2tTmTFYQFxC/dVxEgFLEZRf87QG4M0v6pnlH5FR/GH X-Received: by 2002:a17:906:a43:: with SMTP id x3mr1147ejf.197.1604092958466; Fri, 30 Oct 2020 14:22:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604092958; cv=none; d=google.com; s=arc-20160816; b=MffxPFDcpEiqXejLWPtI3GRQM0eAlPnsED8irVxa3Df/EPLcgDOSm+ltlHOOsl6jM9 VVBOkGzzQEtdZ+TVqpJZAvJQsv8aeBxDfLNGV2f8jnsLLcx9i4a2/Y1SCBAasJouJFtq M+ZlaEqSdbvplb7/peicmU9nsBggmkS5KA0rskCfWbgwpO564u1uf7d101cdSu7BSQhb sZaeQxEWEUIuIwsAjL9I2tdIc6fY+wEnxtngWHBU1DCYrdpCrz+JOmvTe5bbIwRiwYuU dkhUPkXL4Er+WawzRWENzXXAjLVhvzBSdtVDi39NnAR5negUwORv3ACtPyLq9xwqK2z3 x9fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=Jio/RjSRF5CFnmOHSNSwzQSIeZZSaLIkc+Yqb2wq+VI=; b=P4Mf+GJjdKswK0tiUsAfjcmEa3XlbM6UBD4H8w/jyc2iFi3SNMbRC0M6f7SgHIw8dR 2WD3cbzS4QgG+F0nWkfKmv9MI3IcHgrRPZMxwbIQ0v8yWY9Kqmtrhejf53FQ8hqRXJ+t fKN0xBMSUJOHZcTC91Ao8ZoK+qzySm61vNDiBjfniEM522PzuzAGIisTHPTo7PsUscO5 Ylg+ol4XFZORO4pHUMtJr57aY1Ej7ukfJmd9rV37nFm6BmBuJSOCUirLcTWbPgpGsXv3 PnrXlI9+rRfFlSCvl47nutCsv8BgotjStowSPvzdFqh2voB8LezNwUmT1voBQD2gRVML LXVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d19si5126335ejc.188.2020.10.30.14.22.15; Fri, 30 Oct 2020 14:22:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727760AbgJ3VSY (ORCPT + 99 others); Fri, 30 Oct 2020 17:18:24 -0400 Received: from mga18.intel.com ([134.134.136.126]:43848 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727727AbgJ3VSY (ORCPT ); Fri, 30 Oct 2020 17:18:24 -0400 IronPort-SDR: g9UNoPbOUyipBQQMHaNvd8vF39IXkL4YPoNb0O0ykwX2B0UDGyeGmpmGhg93CtO4vaWiaDdjfs sjP7hMz9qzAg== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="156441123" X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="156441123" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 14:18:18 -0700 IronPort-SDR: x1CMf7tda0CkhegdditzFojF91wvC2FBMxdyEDmtdBF0cJVR+gTa+ewQy/QhXol8SvwpeoMFhP aQmQRwyv4kfw== X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="526009529" Received: from rchatre-mobl3.amr.corp.intel.com (HELO [10.212.87.224]) ([10.212.87.224]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 14:18:18 -0700 Subject: Re: [PATCH 0/3] Fix kernfs node reference count leak issues To: Xiaochen Shen , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tony.luck@intel.com, fenghua.yu@intel.com, willemb@google.com Cc: x86@kernel.org, linux-kernel@vger.kernel.org, pei.p.jia@intel.com References: <1604084530-31048-1-git-send-email-xiaochen.shen@intel.com> From: Reinette Chatre Message-ID: <79ccbc0b-32b4-2d02-2790-62350c917d67@intel.com> Date: Fri, 30 Oct 2020 14:18:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1604084530-31048-1-git-send-email-xiaochen.shen@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Apologies, the Subject intended to have a "x86/resctrl:" prefix. On 10/30/2020 12:02 PM, Xiaochen Shen wrote: > Fix several kernfs node reference count leak issues: > (1) Remove superfluous kernfs_get() calls to prevent refcount leak > (2) Add necessary kernfs_put() calls to prevent refcount leak > (3) Follow-up cleanup for the change in previous patch. > > Xiaochen Shen (3): > x86/resctrl: Remove superfluous kernfs_get() calls to prevent refcount > leak > x86/resctrl: Add necessary kernfs_put() calls to prevent refcount leak > x86/resctrl: Clean up unused function parameter in rmdir path > > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 82 ++++++++++++++-------------------- > 1 file changed, 33 insertions(+), 49 deletions(-) >