Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: move ioctl interface definitions to
 separated file
To:     Eric Biggers <ebiggers@kernel.org>
CC:     <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-f2fs-devel@lists.sourceforge.net>
References: <20201030072610.57155-1-yuchao0@huawei.com>
 <20201030165556.GA1097@sol.localdomain>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <9dce9d49-fb13-40cd-eb1f-24212a600beb@huawei.com>
Date:   Sat, 31 Oct 2020 08:32:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20201030165556.GA1097@sol.localdomain>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020/10/31 0:55, Eric Biggers wrote:
> On Fri, Oct 30, 2020 at 03:26:10PM +0800, Chao Yu wrote:
>> +
>> +struct f2fs_gc_range {
>> +	u32 sync;
>> +	u64 start;
>> +	u64 len;
>> +};
> 
> Userspace headers need to use __u32, __u64, etc. instead of u32, u64, etc.

Correct.

> 
> Did you try installing this header, and including it in a userspace program?

Let me do more test before next version.

Thanks,

> 
> - Eric
> .
>