Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1726398pxx; Fri, 30 Oct 2020 18:18:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQWamIqgBe0BBPBGrvKfE7bQDkccwQ0JRSPhpR9xsXegfbZ3ngSH/AhtRpA9hfR3gtmsOv X-Received: by 2002:a17:906:3553:: with SMTP id s19mr5427644eja.195.1604107091196; Fri, 30 Oct 2020 18:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604107091; cv=none; d=google.com; s=arc-20160816; b=CV3UfUKVSUDcyR3GMjE0T4ge0WdjKt0pDoM5jD8CMMkAuBQ5SMcFlwWlWrd8hHN+p8 3fg87Uix48njwMQWIoUtL6t4TxG7lXiGm1lhBu2j5FSp6SQuosV1y1WeBFC+Sjiu3D6l nKwvV7UsKzHL7Hb2FuPbisjaq076wQMnH/YPe2kWSGtgzD0845FB35RIakOHE1y5I45U wBAJJerzYG85KQCho1Ii94eiw+dkzp5Ehri9E075ZXYgFxveQUpyuqLmNELVzt2BMdnp BMvLdwX195ZX6e++ggUiPkA963eb2f9fOf95SK+CylUoTw1/SIxIxMfwryyNdtRU42Au LGFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=ykr2FuJ+kV6rdMsuNxR775RvwHmqgaLMfPRT5FOgcTc=; b=tZrkRFvPa3YSKBb1GRIAczbHqvRWYw/wwAmLeSjUoOmGso8BGsCUJsSonu3DzfvnwI WC+fjb5NqFdPYSs2I5nQ9m+SBgj44HNFtzMyBKLV5INVu2OQ5jPVX1uYWKr4sNhaHcdY CamnMw8DkofSbvBhUWoSp2rf3CtkIp90lSVvfNH7yaugh5ryGpsk0vKF69TDS1TPtxN+ f6GFyc52S7/mRzdFn+5b5m2N1RMPEMa9woNPO0Z9g7AqAz2Q8v5ssi6oTMMcBF9v/H56 6AjvhfipD1oEjpFLBglmhzZ/GH00l8h3EOsyvJjlWs7A8GxLKhtKheNRYtr4O2k7L/pt AXxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n7si2339570ejr.387.2020.10.30.18.17.48; Fri, 30 Oct 2020 18:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726155AbgJaBQZ (ORCPT + 99 others); Fri, 30 Oct 2020 21:16:25 -0400 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:39015 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgJaBQZ (ORCPT ); Fri, 30 Oct 2020 21:16:25 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0UDgVMke_1604106977; Received: from IT-FVFX43SYHV2H.lan(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UDgVMke_1604106977) by smtp.aliyun-inc.com(127.0.0.1); Sat, 31 Oct 2020 09:16:18 +0800 Subject: Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail To: Johannes Weiner Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-5-git-send-email-alex.shi@linux.alibaba.com> <20201029135047.GE599825@cmpxchg.org> <06a5b7d8-bbf2-51b7-1352-2b630186e15f@linux.alibaba.com> <20201030135218.GA666074@cmpxchg.org> From: Alex Shi Message-ID: <8fcf24fc-30ed-1e95-2c50-4034404ab416@linux.alibaba.com> Date: Sat, 31 Oct 2020 09:14:05 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201030135218.GA666074@cmpxchg.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/10/30 下午9:52, Johannes Weiner 写道: > >> From a9ee63a213f40eb4d5a69b52fbb348ff9cd7cf6c Mon Sep 17 00:00:00 2001 >> From: Alex Shi >> Date: Tue, 26 May 2020 16:49:22 +0800 >> Subject: [PATCH v21 04/20] mm/thp: use head for head page in lru_add_page_tail >> >> Since the first parameter is only used by head page, it's better to make >> it explicit. >> >> Signed-off-by: Alex Shi >> Reviewed-by: Kirill A. Shutemov >> Acked-by: Hugh Dickins >> Cc: Andrew Morton >> Cc: Johannes Weiner >> Cc: Matthew Wilcox >> Cc: Hugh Dickins >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org > Acked-by: Johannes Weiner Thanks a lot! Alex