Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1761013pxx; Fri, 30 Oct 2020 19:43:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwh2tNXlCfMz4ISqkytHZrmriGxS16wmhpA/3Bq8RML24C/pZxZIbkHZMigD0Vq2M/gI8j+ X-Received: by 2002:a17:906:c094:: with SMTP id f20mr5636051ejz.550.1604112238343; Fri, 30 Oct 2020 19:43:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604112238; cv=none; d=google.com; s=arc-20160816; b=u1sQ0oM6iQJRg0bFLFpd9xUV847igql4jAIkF1LkQFd4u1cN6Rs4oWQsFFFW1NMX+r HQMO5XRsvVOCMYdbm4Tfc5CGh/+Sf78JA446KcmLqSvtrHTY1ZntFNvfWenhq+bqmYbh nHkz3ROprTR5hB4lzDRjOUENeIHrb2ni1JaMhBxeLs5EM7mZa7T1k50bCoXB8yTJYZKT +YhlNg9NWmcmByc/dmhCcMgkShgkQx1eNAqAACCmWha+hrDrKWzORoVqqHC6oV119bfE KC1PX6o1TgVuCRzVlf05Z8jZQHJHUSbbaoQpQQw1x6FoRdIAIHiHBa11TYidyYYOA0pQ LbNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=AR2OTRsY1F8bFAKy1jm0yfCPyeQDLxyiHXykyqIyJac=; b=mRnHIie2RdHSbkfb7zUUm+f/Ova5FzXbUPZwZ7SJGfChlWYpXOjafrVWUQZ9PJfq6Q 9eg0SgAz6doBagckP2VxEsonvsKreO0GCf24FH370/U5NxgSPl2wwbg2q6d+LRUzYIPy CsNGo+bGsdNEVxzccBYSW/wG9lghcJcNJ7jQOEr0a+oMAqNiuq07MB0PtLV/BCoMIvco nh2vAeDW34eeKtRRCP4u9OrNoabo1AnjLc52TpYdqxdROkaJlGueCpgf0GBZHm1H5XAr V7xGaxkRgm3jAI+XNDb9f9vuNbNa/o4MvjipzL3nlv5kRcQOeSjbSHfKwj40eavfvKWN jAqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si501441edj.545.2020.10.30.19.43.35; Fri, 30 Oct 2020 19:43:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725856AbgJaCmJ (ORCPT + 99 others); Fri, 30 Oct 2020 22:42:09 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6675 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgJaCmI (ORCPT ); Fri, 30 Oct 2020 22:42:08 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CNNk70yFHz15NwZ; Sat, 31 Oct 2020 10:42:07 +0800 (CST) Received: from [10.174.176.180] (10.174.176.180) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Sat, 31 Oct 2020 10:42:05 +0800 Subject: Re: [PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_core_suspend/resume __maybe_unused To: , , , References: <20200811021225.50296-1-yuehaibing@huawei.com> CC: , , , From: Yuehaibing Message-ID: <4fa1e3fe-c254-6924-ed3b-a6fd4ca88e41@huawei.com> Date: Sat, 31 Oct 2020 10:42:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20200811021225.50296-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.180] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping... On 2020/8/11 10:12, YueHaibing wrote: > If CONFIG_PM is not set, gcc warns: > > drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: > warning: ‘cdn_dp_resume’ defined but not used [-Wunused-function] > > Mark them __maybe_unused to fix this. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > index a4a45daf93f2..413b0e90f10f 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -1107,7 +1107,7 @@ static const struct component_ops cdn_dp_component_ops = { > .unbind = cdn_dp_unbind, > }; > > -static int cdn_dp_suspend(struct device *dev) > +static __maybe_unused int cdn_dp_suspend(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > int ret = 0; > @@ -1121,7 +1121,7 @@ static int cdn_dp_suspend(struct device *dev) > return ret; > } > > -static int cdn_dp_resume(struct device *dev) > +static __maybe_unused int cdn_dp_resume(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > >